Re: [PATCH] bpfilter: Fix build error with CONFIG_BPFILTER_UMH

2020-10-15 Thread Yuehaibing
On 2020/10/16 3:57, Alexei Starovoitov wrote: > On Thu, Oct 15, 2020 at 12:26 PM Jakub Kicinski wrote: >> >> On Thu, 15 Oct 2020 12:03:14 -0700 Alexei Starovoitov wrote: >>> On Thu, Oct 15, 2020 at 11:56 AM Jakub Kicinski wrote: How so? It's using in-tree headers instead of system ones. >

Re: [PATCH] bpfilter: Fix build error with CONFIG_BPFILTER_UMH

2020-10-15 Thread Alexei Starovoitov
On Thu, Oct 15, 2020 at 12:26 PM Jakub Kicinski wrote: > > On Thu, 15 Oct 2020 12:03:14 -0700 Alexei Starovoitov wrote: > > On Thu, Oct 15, 2020 at 11:56 AM Jakub Kicinski wrote: > > > How so? It's using in-tree headers instead of system ones. > > > Many samples seem to be doing the same thing. >

Re: [PATCH] bpfilter: Fix build error with CONFIG_BPFILTER_UMH

2020-10-15 Thread Jakub Kicinski
On Thu, 15 Oct 2020 12:03:14 -0700 Alexei Starovoitov wrote: > On Thu, Oct 15, 2020 at 11:56 AM Jakub Kicinski wrote: > > How so? It's using in-tree headers instead of system ones. > > Many samples seem to be doing the same thing. > > There is no such thing as "usr/include" in the kernel build

Re: [PATCH] bpfilter: Fix build error with CONFIG_BPFILTER_UMH

2020-10-15 Thread Alexei Starovoitov
On Thu, Oct 15, 2020 at 11:56 AM Jakub Kicinski wrote: > > On Thu, 15 Oct 2020 11:53:08 -0700 Alexei Starovoitov wrote: > > On Thu, Oct 15, 2020 at 9:37 AM Jakub Kicinski wrote: > > > On Wed, 14 Oct 2020 17:17:49 +0800 YueHaibing wrote: > > > > IF CONFIG_BPFILTER_UMH is set, building fails: > > >

Re: [PATCH] bpfilter: Fix build error with CONFIG_BPFILTER_UMH

2020-10-15 Thread Jakub Kicinski
On Thu, 15 Oct 2020 11:53:08 -0700 Alexei Starovoitov wrote: > On Thu, Oct 15, 2020 at 9:37 AM Jakub Kicinski wrote: > > On Wed, 14 Oct 2020 17:17:49 +0800 YueHaibing wrote: > > > IF CONFIG_BPFILTER_UMH is set, building fails: > > > > > > In file included from /usr/include/sys/socket.h:33:0, > >

Re: [PATCH] bpfilter: Fix build error with CONFIG_BPFILTER_UMH

2020-10-15 Thread Alexei Starovoitov
On Thu, Oct 15, 2020 at 9:37 AM Jakub Kicinski wrote: > > On Wed, 14 Oct 2020 17:17:49 +0800 YueHaibing wrote: > > IF CONFIG_BPFILTER_UMH is set, building fails: > > > > In file included from /usr/include/sys/socket.h:33:0, > > from net/bpfilter/main.c:6: > > /usr/include/bits/soc

Re: [PATCH] bpfilter: Fix build error with CONFIG_BPFILTER_UMH

2020-10-15 Thread Jakub Kicinski
On Wed, 14 Oct 2020 17:17:49 +0800 YueHaibing wrote: > IF CONFIG_BPFILTER_UMH is set, building fails: > > In file included from /usr/include/sys/socket.h:33:0, > from net/bpfilter/main.c:6: > /usr/include/bits/socket.h:390:10: fatal error: asm/socket.h: No such file or > director

[PATCH] bpfilter: Fix build error with CONFIG_BPFILTER_UMH

2020-10-14 Thread YueHaibing
IF CONFIG_BPFILTER_UMH is set, building fails: In file included from /usr/include/sys/socket.h:33:0, from net/bpfilter/main.c:6: /usr/include/bits/socket.h:390:10: fatal error: asm/socket.h: No such file or directory #include ^~ compilation terminated. scr

Re: [PATCH] bpfilter: fix build error

2018-06-20 Thread Matteo Croce
On Wed, Jun 20, 2018 at 12:39 PM Stefano Brivio wrote: > > On Tue, 19 Jun 2018 17:16:20 +0200 > Matteo Croce wrote: > > > bpfilter Makefile assumes that the system locale is en_US, and the > > parsing of objdump output fails. > > Set LC_ALL=C and, while at it, rewrite the objdump parsing so it sp

Re: [PATCH] bpfilter: fix build error

2018-06-20 Thread Stefano Brivio
On Tue, 19 Jun 2018 17:16:20 +0200 Matteo Croce wrote: > bpfilter Makefile assumes that the system locale is en_US, and the > parsing of objdump output fails. > Set LC_ALL=C and, while at it, rewrite the objdump parsing so it spawns > only 2 processes instead of 7. > > Fixes: d2ba09c17a064 ("net

Re: [PATCH] bpfilter: fix build error

2018-06-19 Thread David Miller
From: Matteo Croce Date: Tue, 19 Jun 2018 17:16:20 +0200 > bpfilter Makefile assumes that the system locale is en_US, and the > parsing of objdump output fails. > Set LC_ALL=C and, while at it, rewrite the objdump parsing so it spawns > only 2 processes instead of 7. > > Fixes: d2ba09c17a064 ("n

[PATCH] bpfilter: fix build error

2018-06-19 Thread Matteo Croce
bpfilter Makefile assumes that the system locale is en_US, and the parsing of objdump output fails. Set LC_ALL=C and, while at it, rewrite the objdump parsing so it spawns only 2 processes instead of 7. Fixes: d2ba09c17a064 ("net: add skeleton of bpfilter kernel module") Signed-off-by: Matteo Croc