Re: [PATCH] bpfilter: allow to build bpfilter_umh as a module without static library

2020-07-14 Thread Alexei Starovoitov
On Wed, Jul 1, 2020 at 10:50 AM Masahiro Yamada wrote: > > On Thu, Jul 2, 2020 at 2:46 AM Alexei Starovoitov > wrote: > > > > On Wed, Jul 01, 2020 at 06:26:44PM +0900, Masahiro Yamada wrote: > > > Originally, bpfilter_umh was linked with -static only when > > > CONFIG_BPFILTER_UMH=y. > > > > > >

Re: [PATCH] bpfilter: allow to build bpfilter_umh as a module without static library

2020-07-01 Thread Masahiro Yamada
On Thu, Jul 2, 2020 at 2:46 AM Alexei Starovoitov wrote: > > On Wed, Jul 01, 2020 at 06:26:44PM +0900, Masahiro Yamada wrote: > > Originally, bpfilter_umh was linked with -static only when > > CONFIG_BPFILTER_UMH=y. > > > > Commit 8a2cc0505cc4 ("bpfilter: use 'userprogs' syntax to build > > bpfilt

Re: [PATCH] bpfilter: allow to build bpfilter_umh as a module without static library

2020-07-01 Thread Alexei Starovoitov
On Wed, Jul 01, 2020 at 06:26:44PM +0900, Masahiro Yamada wrote: > Originally, bpfilter_umh was linked with -static only when > CONFIG_BPFILTER_UMH=y. > > Commit 8a2cc0505cc4 ("bpfilter: use 'userprogs' syntax to build > bpfilter_umh") silently, accidentally dropped the CONFIG_BPFILTER_UMH=y > tes

Re: [PATCH] bpfilter: allow to build bpfilter_umh as a module without static library

2020-07-01 Thread Michal Kubecek
On Wed, Jul 01, 2020 at 06:26:44PM +0900, Masahiro Yamada wrote: > Originally, bpfilter_umh was linked with -static only when > CONFIG_BPFILTER_UMH=y. > > Commit 8a2cc0505cc4 ("bpfilter: use 'userprogs' syntax to build > bpfilter_umh") silently, accidentally dropped the CONFIG_BPFILTER_UMH=y > tes

[PATCH] bpfilter: allow to build bpfilter_umh as a module without static library

2020-07-01 Thread Masahiro Yamada
Originally, bpfilter_umh was linked with -static only when CONFIG_BPFILTER_UMH=y. Commit 8a2cc0505cc4 ("bpfilter: use 'userprogs' syntax to build bpfilter_umh") silently, accidentally dropped the CONFIG_BPFILTER_UMH=y test in the Makefile. Revive it in order to link it dynamically when CONFIG_BPFI