Re: [PATCH] bpf: fix double-fdput in replace_map_fd_with_map_ptr()

2016-04-26 Thread David Miller
From: Jann Horn Date: Tue, 26 Apr 2016 22:26:26 +0200 > When bpf(BPF_PROG_LOAD, ...) was invoked with a BPF program whose bytecode > references a non-map file descriptor as a map file descriptor, the error > handling code called fdput() twice instead of once (in __bpf_map_get() and > in replace_m

Re: [PATCH] bpf: fix double-fdput in replace_map_fd_with_map_ptr()

2016-04-26 Thread Daniel Borkmann
On 04/26/2016 10:26 PM, Jann Horn wrote: When bpf(BPF_PROG_LOAD, ...) was invoked with a BPF program whose bytecode references a non-map file descriptor as a map file descriptor, the error handling code called fdput() twice instead of once (in __bpf_map_get() and in replace_map_fd_with_map_ptr())

Re: [PATCH] bpf: fix double-fdput in replace_map_fd_with_map_ptr()

2016-04-26 Thread Alexei Starovoitov
On Tue, Apr 26, 2016 at 10:26:26PM +0200, Jann Horn wrote: > When bpf(BPF_PROG_LOAD, ...) was invoked with a BPF program whose bytecode > references a non-map file descriptor as a map file descriptor, the error > handling code called fdput() twice instead of once (in __bpf_map_get() and > in replac

[PATCH] bpf: fix double-fdput in replace_map_fd_with_map_ptr()

2016-04-26 Thread Jann Horn
When bpf(BPF_PROG_LOAD, ...) was invoked with a BPF program whose bytecode references a non-map file descriptor as a map file descriptor, the error handling code called fdput() twice instead of once (in __bpf_map_get() and in replace_map_fd_with_map_ptr()). If the file descriptor table of the curre