Re: [PATCH] bpf: Prevent double bpf_prog_put call from bpf_tracing_prog_attach

2021-01-11 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf.git (refs/heads/master): On Mon, 11 Jan 2021 20:16:50 +0100 you wrote: > The bpf_tracing_prog_attach error path calls bpf_prog_put > on prog, which causes refcount underflow when it's called > from link_create function. > > link_create > prog = bpf_

Re: [PATCH] bpf: Prevent double bpf_prog_put call from bpf_tracing_prog_attach

2021-01-11 Thread Andrii Nakryiko
On Mon, Jan 11, 2021 at 1:17 PM Jiri Olsa wrote: > > On Mon, Jan 11, 2021 at 12:34:48PM -0800, Andrii Nakryiko wrote: > > On Mon, Jan 11, 2021 at 11:18 AM Jiri Olsa wrote: > > > > > > The bpf_tracing_prog_attach error path calls bpf_prog_put > > > on prog, which causes refcount underflow when it'

Re: [PATCH] bpf: Prevent double bpf_prog_put call from bpf_tracing_prog_attach

2021-01-11 Thread Jiri Olsa
On Mon, Jan 11, 2021 at 12:34:48PM -0800, Andrii Nakryiko wrote: > On Mon, Jan 11, 2021 at 11:18 AM Jiri Olsa wrote: > > > > The bpf_tracing_prog_attach error path calls bpf_prog_put > > on prog, which causes refcount underflow when it's called > > from link_create function. > > > > link_create

Re: [PATCH] bpf: Prevent double bpf_prog_put call from bpf_tracing_prog_attach

2021-01-11 Thread Andrii Nakryiko
On Mon, Jan 11, 2021 at 11:18 AM Jiri Olsa wrote: > > The bpf_tracing_prog_attach error path calls bpf_prog_put > on prog, which causes refcount underflow when it's called > from link_create function. > > link_create > prog = bpf_prog_get <-- get > ... > tracing_bpf_link

Re: [PATCH] bpf: Prevent double bpf_prog_put call from bpf_tracing_prog_attach

2021-01-11 Thread Toke Høiland-Jørgensen
Jiri Olsa writes: > The bpf_tracing_prog_attach error path calls bpf_prog_put > on prog, which causes refcount underflow when it's called > from link_create function. > > link_create > prog = bpf_prog_get <-- get > ... > tracing_bpf_link_attach(prog.. > bpf_tracin

[PATCH] bpf: Prevent double bpf_prog_put call from bpf_tracing_prog_attach

2021-01-11 Thread Jiri Olsa
The bpf_tracing_prog_attach error path calls bpf_prog_put on prog, which causes refcount underflow when it's called from link_create function. link_create prog = bpf_prog_get <-- get ... tracing_bpf_link_attach(prog.. bpf_tracing_prog_attach(prog.. out_put_