Re: [PATCH] bnx2x: Prevent load reordering in tx completion processing

2019-07-21 Thread David Miller
From: Brian King Date: Mon, 15 Jul 2019 16:41:50 -0500 > This patch fixes an issue seen on Power systems with bnx2x which results > in the skb is NULL WARN_ON in bnx2x_free_tx_pkt firing due to the skb > pointer getting loaded in bnx2x_free_tx_pkt prior to the hw_cons > load in bnx2x_tx_int. Addi

Re: [PATCH] bnx2x: Prevent load reordering in tx completion processing

2019-07-18 Thread David Miller
From: Brian King Date: Mon, 15 Jul 2019 16:41:50 -0500 > This patch fixes an issue seen on Power systems with bnx2x which results > in the skb is NULL WARN_ON in bnx2x_free_tx_pkt firing due to the skb > pointer getting loaded in bnx2x_free_tx_pkt prior to the hw_cons > load in bnx2x_tx_int. Addi

Re: [EXT] [PATCH] bnx2x: Prevent load reordering in tx completion processing

2019-07-18 Thread Brian King
;> Subject: [EXT] [PATCH] bnx2x: Prevent load reordering in tx completion >> processing >> >> External Email >> >> -- >> This patch fixes an issue seen on Power systems with bnx2x which resu

RE: [EXT] [PATCH] bnx2x: Prevent load reordering in tx completion processing

2019-07-18 Thread Manish Chopra
> -Original Message- > From: Brian King > Sent: Tuesday, July 16, 2019 3:12 AM > To: GR-everest-linux-l2 > Cc: Sudarsana Reddy Kalluru ; Ariel Elior > ; netdev@vger.kernel.org; Brian King > > Subject: [EXT] [PATCH] bnx2x: Prevent load reordering in tx

Re: [PATCH] bnx2x: Prevent load reordering in tx completion processing

2019-07-17 Thread David Miller
From: Brian King Date: Mon, 15 Jul 2019 16:41:50 -0500 > This patch fixes an issue seen on Power systems with bnx2x which results > in the skb is NULL WARN_ON in bnx2x_free_tx_pkt firing due to the skb > pointer getting loaded in bnx2x_free_tx_pkt prior to the hw_cons > load in bnx2x_tx_int. Addi

[PATCH] bnx2x: Prevent load reordering in tx completion processing

2019-07-15 Thread Brian King
This patch fixes an issue seen on Power systems with bnx2x which results in the skb is NULL WARN_ON in bnx2x_free_tx_pkt firing due to the skb pointer getting loaded in bnx2x_free_tx_pkt prior to the hw_cons load in bnx2x_tx_int. Adding a read memory barrier resolves the issue. Signed-off-by: Bria