Re: [PATCH] atl1: fix frame length bug

2008-01-18 Thread Jeff Garzik
Jay Cliburn wrote: The driver sets up the hardware to accept a frame with max length equal to MTU + Ethernet header + FCS + VLAN tag, but we neglect to add the VLAN tag size to the ingress buffer. When a VLAN-tagged frame arrives, the hardware passes it, but bad things happen because the buffer

Re: [PATCH] atl1: fix frame length bug

2008-01-18 Thread Jay Cliburn
On Mon, 14 Jan 2008 20:04:28 -0600 Jay Cliburn <[EMAIL PROTECTED]> wrote: > On Mon, 14 Jan 2008 19:56:41 -0600 > Jay Cliburn <[EMAIL PROTECTED]> wrote: > > > The driver sets up the hardware to accept a frame with max length > > equal to MTU + Ethernet header + FCS + VLAN tag, but we neglect to >

Re: [PATCH] atl1: fix frame length bug

2008-01-14 Thread Jay Cliburn
On Mon, 14 Jan 2008 19:56:41 -0600 Jay Cliburn <[EMAIL PROTECTED]> wrote: > The driver sets up the hardware to accept a frame with max length > equal to MTU + Ethernet header + FCS + VLAN tag, but we neglect to > add the VLAN tag size to the ingress buffer. When a VLAN-tagged > frame arrives, the

[PATCH] atl1: fix frame length bug

2008-01-14 Thread Jay Cliburn
The driver sets up the hardware to accept a frame with max length equal to MTU + Ethernet header + FCS + VLAN tag, but we neglect to add the VLAN tag size to the ingress buffer. When a VLAN-tagged frame arrives, the hardware passes it, but bad things happen because the buffer is too small. This p