Re: [PATCH] ath9k: release allocated buffer if timed out

Brian Norris writes: > On Wed, May 13, 2020 at 12:02 PM Brian Norris > wrote: >> >> On Wed, May 13, 2020 at 12:05 AM Kalle Valo wrote: >> > Actually it's already reverted in -next, nobody just realised that it's >> > a regression from commit 728c1e2a05e4: >> > >> > ced21a4c726b ath9k: Fix use-

Re: [PATCH] ath9k: release allocated buffer if timed out

On Wed, May 13, 2020 at 12:02 PM Brian Norris wrote: > > On Wed, May 13, 2020 at 12:05 AM Kalle Valo wrote: > > Actually it's already reverted in -next, nobody just realised that it's > > a regression from commit 728c1e2a05e4: > > > > ced21a4c726b ath9k: Fix use-after-free Read in htc_connect_ser

Re: [PATCH] ath9k: release allocated buffer if timed out

On Tue, May 12, 2020 at 8:25 PM Navid Emamdoost wrote: > I found this via static analysis and as a result, did had the inputs > to test it with (like the way fuzzing works). Fuzzing is dynamic analysis, so I'm not sure how that fits. > It may be beneficial if you could point me to any testing >

Re: [PATCH] ath9k: release allocated buffer if timed out

On Wed, May 13, 2020 at 12:05 AM Kalle Valo wrote: > Actually it's already reverted in -next, nobody just realised that it's > a regression from commit 728c1e2a05e4: > > ced21a4c726b ath9k: Fix use-after-free Read in htc_connect_service Nice. > v5.8-rc1 should be the first release having the fix

Re: [PATCH] ath9k: release allocated buffer if timed out

Brian Norris writes: > On Fri, Sep 6, 2019 at 11:59 AM Navid Emamdoost > wrote: >> >> In ath9k_wmi_cmd, the allocated network buffer needs to be released >> if timeout happens. Otherwise memory will be leaked. >> >> Signed-off-by: Navid Emamdoost > > I wonder, did you actually test your patches

Re: [PATCH] ath9k: release allocated buffer if timed out

Hi Brian, On Tue, May 12, 2020 at 11:57 AM Brian Norris wrote: > > On Fri, Sep 6, 2019 at 11:59 AM Navid Emamdoost > wrote: > > > > In ath9k_wmi_cmd, the allocated network buffer needs to be released > > if timeout happens. Otherwise memory will be leaked. > > > > Signed-off-by: Navid Emamdoost

Re: [PATCH] ath9k: release allocated buffer if timed out

On Fri, Sep 6, 2019 at 11:59 AM Navid Emamdoost wrote: > > In ath9k_wmi_cmd, the allocated network buffer needs to be released > if timeout happens. Otherwise memory will be leaked. > > Signed-off-by: Navid Emamdoost I wonder, did you actually test your patches? I ask, because it seems that all