Re: [PATCH] ath: move spin_lock_bh to spin_lock in tasklet

2019-02-07 Thread Kalle Valo
Zhiwei Jiang wrote: > as you are already in a tasklet, it is unnecessary to call > spin_lock_bh, because softirq already disable BH. > > Signed-off-by: Zhiwei Jiang > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. b789f333d7ac ath: move spin_lock_bh to spin_lo

Re: [PATCH] ath: move spin_lock_bh to spin_lock in tasklet

2019-01-22 Thread Kalle Valo
姜智伟 writes: > Will do, thanks! Also don't send HTML mail :) Maillists drop those automatically. -- Kalle Valo

Re: [PATCH] ath: move spin_lock_bh to spin_lock in tasklet

2019-01-22 Thread Kalle Valo
Zhiwei Jiang writes: > as you are already in a tasklet, it is unnecessary to call > spin_lock_bh, because softirq already disable BH. > > Signed-off-by: Zhiwei Jiang If you post a new version you should mark it as "v2": https://wireless.wiki.kernel.org/en/developers/documentation/submittingpat

[PATCH] ath: move spin_lock_bh to spin_lock in tasklet

2019-01-22 Thread Zhiwei Jiang
as you are already in a tasklet, it is unnecessary to call spin_lock_bh, because softirq already disable BH. Signed-off-by: Zhiwei Jiang --- drivers/net/wireless/ath/ath9k/htc_drv_txrx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/htc_

Re: [PATCH] ath: move spin_lock_bh to spin_lock in tasklet

2019-01-22 Thread Dan Carpenter
Hi Zhiwei, Thank you for the patch! Perhaps something to improve: url: https://github.com/0day-ci/linux/commits/Zhiwei-Jiang/ath-move-spin_lock_bh-to-spin_lock-in-tasklet/20190121-185529 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master smatch w

[PATCH] ath: move spin_lock_bh to spin_lock in tasklet

2019-01-19 Thread Zhiwei Jiang
as you are already in a tasklet, it is unnecessary to call spin_lock_bh, because softirq already disable BH. Signed-off-by: Zhiwei Jiang --- drivers/net/wireless/ath/ath9k/htc_drv_txrx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/htc_dr