Re: [PATCH] at803x: fix reset handling

2016-03-23 Thread David Miller
From: Sergei Shtylyov Date: Wed, 23 Mar 2016 00:44:40 +0300 > The driver of course "knows" that the chip's reset signal is active low, > so it drives the GPIO to 0 to reset the PHY and to 1 otherwise; however > all this will only work iff the GPIO is specified as active-high in the > device t

Re: [PATCH] at803x: fix reset handling

2016-03-23 Thread Sergei Shtylyov
Hello. On 03/23/2016 02:56 PM, Daniel Mack wrote: I added the author of 13a56b449325 to Cc. Thanks for doing that! I forgot to do it, sorry. On Wed, Mar 23, 2016 at 12:44:40AM +0300, Sergei Shtylyov wrote: The driver of course "knows" that the chip's reset signal is active low, so i

Re: [PATCH] at803x: fix reset handling

2016-03-23 Thread Sergei Shtylyov
On 03/23/2016 09:45 AM, Uwe Kleine-König wrote: On Wed, Mar 23, 2016 at 12:44:40AM +0300, Sergei Shtylyov wrote: The driver of course "knows" that the chip's reset signal is active low, so it drives the GPIO to 0 to reset the PHY and to 1 otherwise; however all this will only work iff the GPI

Re: [PATCH] at803x: fix reset handling

2016-03-23 Thread Daniel Mack
Hi Sergei, Hi Uwe, On 03/23/2016 07:45 AM, Uwe Kleine-König wrote: > I added the author of 13a56b449325 to Cc. Thanks for doing that! > On Wed, Mar 23, 2016 at 12:44:40AM +0300, Sergei Shtylyov wrote: >> The driver of course "knows" that the chip's reset signal is active low, >> so it drives th

Re: [PATCH] at803x: fix reset handling

2016-03-22 Thread Uwe Kleine-König
Hello, I added the author of 13a56b449325 to Cc. On Wed, Mar 23, 2016 at 12:44:40AM +0300, Sergei Shtylyov wrote: > The driver of course "knows" that the chip's reset signal is active low, > so it drives the GPIO to 0 to reset the PHY and to 1 otherwise; however > all this will only work iff th

[PATCH] at803x: fix reset handling

2016-03-22 Thread Sergei Shtylyov
The driver of course "knows" that the chip's reset signal is active low, so it drives the GPIO to 0 to reset the PHY and to 1 otherwise; however all this will only work iff the GPIO is specified as active-high in the device tree! I think both the driver and the device trees (if there are any -