Re: [PATCH] arm64: bpf: fix buffer pointer

2015-11-18 Thread David Miller
From: Zi Shen Lim Date: Wed, 18 Nov 2015 00:56:02 -0800 > During code review, I noticed we were passing a bad buffer pointer > to bpf_load_pointer helper function called by jitted code. > > Point to the buffer allocated by JIT, so we don't silently corrupt > other parts of the stack. > > Signed

Re: [PATCH] arm64: bpf: fix buffer pointer

2015-11-18 Thread Shi, Yang
On 11/18/2015 1:41 PM, Z Lim wrote: On Wed, Nov 18, 2015 at 1:07 PM, Shi, Yang wrote: On 11/18/2015 12:56 AM, Zi Shen Lim wrote: emit_a64_mov_i64(r3, size, ctx); - emit(A64_ADD_I(1, r4, fp, MAX_BPF_STACK), ctx); + emit(A64_SUB_I(1, r4, fp, STACK_SIZ

Re: [PATCH] arm64: bpf: fix buffer pointer

2015-11-18 Thread Z Lim
On Wed, Nov 18, 2015 at 1:07 PM, Shi, Yang wrote: > On 11/18/2015 12:56 AM, Zi Shen Lim wrote: >> emit_a64_mov_i64(r3, size, ctx); >> - emit(A64_ADD_I(1, r4, fp, MAX_BPF_STACK), ctx); >> + emit(A64_SUB_I(1, r4, fp, STACK_SIZE), ctx); > > > Should not it

Re: [PATCH] arm64: bpf: fix buffer pointer

2015-11-18 Thread Shi, Yang
On 11/18/2015 12:56 AM, Zi Shen Lim wrote: During code review, I noticed we were passing a bad buffer pointer to bpf_load_pointer helper function called by jitted code. Point to the buffer allocated by JIT, so we don't silently corrupt other parts of the stack. Signed-off-by: Zi Shen Lim ---

Re: [PATCH] arm64: bpf: fix buffer pointer

2015-11-18 Thread David Miller
From: Zi Shen Lim Date: Wed, 18 Nov 2015 00:56:02 -0800 > During code review, I noticed we were passing a bad buffer pointer > to bpf_load_pointer helper function called by jitted code. > > Point to the buffer allocated by JIT, so we don't silently corrupt > other parts of the stack. > > Signed

[PATCH] arm64: bpf: fix buffer pointer

2015-11-18 Thread Zi Shen Lim
During code review, I noticed we were passing a bad buffer pointer to bpf_load_pointer helper function called by jitted code. Point to the buffer allocated by JIT, so we don't silently corrupt other parts of the stack. Signed-off-by: Zi Shen Lim --- arch/arm64/net/bpf_jit_comp.c | 27 ++