Re: [PATCH] amd-xgbe: fix unsigned comparison against less than zero

2016-11-15 Thread Tom Lendacky
On 11/15/2016 6:18 AM, Colin King wrote: > From: Colin Ian King > > Comparing unsigned int ret to less than zero for an error status > check is never true. Fix this by making ret a signed int. Reduce > scope of ret too. > > Found with static analysis by CoverityScan, CID 1377750 Thanks Colin,

[PATCH] amd-xgbe: fix unsigned comparison against less than zero

2016-11-15 Thread Colin King
From: Colin Ian King Comparing unsigned int ret to less than zero for an error status check is never true. Fix this by making ret a signed int. Reduce scope of ret too. Found with static analysis by CoverityScan, CID 1377750 Signed-off-by: Colin Ian King --- drivers/net/ethernet/amd/xgbe/xgb