Re: [PATCH] Shrink struct dst_entry a bit

2007-03-13 Thread Eric Dumazet
On Tuesday 13 March 2007 15:44, Eric Dumazet wrote: > Also, 'lastuse' could use a u32 too, I even had a patch for this one... Here is the patch I have here for lastuse u32 conversion, not for inclusion yet because not yet tested (only compiled) [PATCH] NET : abstract lastuse (from struct dst_en

Re: [PATCH] Shrink struct dst_entry a bit

2007-03-13 Thread Eric Dumazet
On Tuesday 13 March 2007 15:31, Andi Kleen wrote: > Ok. When you do such changes you should always add a comment, otherwise > it will be always destroyed with the next change. > > But it seems highly fragile to me anyways because it depends on the exact > value of RTAX_MAX which tends to change r

Re: [PATCH] Shrink struct dst_entry a bit

2007-03-13 Thread Andi Kleen
On Tuesday 13 March 2007 15:10, Eric Dumazet wrote: > On Tuesday 13 March 2007 14:48, Andi Kleen wrote: > > The ICMP rate limiting state can be shorts, we don't send that many ICMPs. > > Changing flags to short and reorder fields to be sorted by size to avoid > > holes. Move cold fields towards the

Re: [PATCH] Shrink struct dst_entry a bit

2007-03-13 Thread Eric Dumazet
On Tuesday 13 March 2007 14:48, Andi Kleen wrote: > The ICMP rate limiting state can be shorts, we don't send that many ICMPs. > Changing flags to short and reorder fields to be sorted by size to avoid > holes. Move cold fields towards the end. > Nope, you cannot break the reordering I've done one

[PATCH] Shrink struct dst_entry a bit

2007-03-13 Thread Andi Kleen
The ICMP rate limiting state can be shorts, we don't send that many ICMPs. Changing flags to short and reorder fields to be sorted by size to avoid holes. Move cold fields towards the end. Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> Index: linux-2.6.21-rc3-net/include/net/dst.h ===