Re: [PATCH] Remove notifier block from chain when register_netdevice_notifier fails

2007-11-14 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Wed, 14 Nov 2007 21:37:17 +0800 > Acked-by: Herbert Xu <[EMAIL PROTECTED]> Indeed, good catch, patch applied. Thanks! - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info a

Re: [PATCH] Remove notifier block from chain when register_netdevice_notifier fails

2007-11-14 Thread Herbert Xu
On Wed, Nov 14, 2007 at 04:47:24PM +0300, Pavel Emelyanov wrote: > > BTW, I have one more question I can't find the answer to by > myself. Why the unregister_netdevice_notifier doesn't produce > the GOING_DOWN-DOWN-UNREGISTER event sequence for the notifier > block which is being unregistered? Wa

Re: [PATCH] Remove notifier block from chain when register_netdevice_notifier fails

2007-11-14 Thread Pavel Emelyanov
Herbert Xu wrote: > On Wed, Nov 14, 2007 at 03:08:03PM +0300, Pavel Emelyanov wrote: >> Commit fcc5a03ac42564e9e255c1134dda47442289e466 makes the >> register_netdevice_notifier() handle the error from the >> NETDEV_REGISTER event, sent to the registering block. >> >> The bad news is that in this c

Re: [PATCH] Remove notifier block from chain when register_netdevice_notifier fails

2007-11-14 Thread Herbert Xu
On Wed, Nov 14, 2007 at 03:08:03PM +0300, Pavel Emelyanov wrote: > Commit fcc5a03ac42564e9e255c1134dda47442289e466 makes the > register_netdevice_notifier() handle the error from the > NETDEV_REGISTER event, sent to the registering block. > > The bad news is that in this case the notifier block i

[PATCH] Remove notifier block from chain when register_netdevice_notifier fails

2007-11-14 Thread Pavel Emelyanov
Commit fcc5a03ac42564e9e255c1134dda47442289e466 makes the register_netdevice_notifier() handle the error from the NETDEV_REGISTER event, sent to the registering block. The bad news is that in this case the notifier block is not removed from the list, but the error is returned to the caller. In