Re: [PATCH] RDS: Simplify code

2016-09-05 Thread santosh.shilim...@oracle.com
On 9/4/16 11:23 AM, Leon Romanovsky wrote: On Sun, Sep 04, 2016 at 05:57:20PM +0200, Christophe JAILLET wrote: Le 04/09/2016 à 14:20, Leon Romanovsky a écrit : On Sat, Sep 03, 2016 at 07:33:29AM +0200, Christophe JAILLET wrote: Calling 'list_splice' followed by 'INIT_LIST_HEAD' is equivalent t

Re: [PATCH] RDS: Simplify code

2016-09-04 Thread Leon Romanovsky
On Mon, Sep 05, 2016 at 06:38:21AM +0200, Christophe JAILLET wrote: > Le 04/09/2016 à 20:23, Leon Romanovsky a écrit : > >On Sun, Sep 04, 2016 at 05:57:20PM +0200, Christophe JAILLET wrote: > >>Le 04/09/2016 à 14:20, Leon Romanovsky a écrit : > >>>On Sat, Sep 03, 2016 at 07:33:29AM +0200, Christoph

Re: [PATCH] RDS: Simplify code

2016-09-04 Thread Leon Romanovsky
On Sun, Sep 04, 2016 at 05:57:20PM +0200, Christophe JAILLET wrote: > Le 04/09/2016 à 14:20, Leon Romanovsky a écrit : > >On Sat, Sep 03, 2016 at 07:33:29AM +0200, Christophe JAILLET wrote: > >>Calling 'list_splice' followed by 'INIT_LIST_HEAD' is equivalent to > >>'list_splice_init'. > >It is not

Re: [PATCH] RDS: Simplify code

2016-09-04 Thread Christophe JAILLET
Le 04/09/2016 à 14:20, Leon Romanovsky a écrit : On Sat, Sep 03, 2016 at 07:33:29AM +0200, Christophe JAILLET wrote: Calling 'list_splice' followed by 'INIT_LIST_HEAD' is equivalent to 'list_splice_init'. It is not 100% accurate list_splice(y, z) INIT_LIST_HEAD(y) ==> if (!list_empty(y))

Re: [PATCH] RDS: Simplify code

2016-09-04 Thread Leon Romanovsky
On Sat, Sep 03, 2016 at 07:33:29AM +0200, Christophe JAILLET wrote: > Calling 'list_splice' followed by 'INIT_LIST_HEAD' is equivalent to > 'list_splice_init'. It is not 100% accurate list_splice(y, z) INIT_LIST_HEAD(y) ==> if (!list_empty(y)) __list_splice(y, z, z>next); INIT_LIST_HEAD(y)

[PATCH] RDS: Simplify code

2016-09-02 Thread Christophe JAILLET
Calling 'list_splice' followed by 'INIT_LIST_HEAD' is equivalent to 'list_splice_init'. This has been spotted with the following coccinelle script: / @@ expression y,z; @@ - list_splice(y,z); - INIT_LIST_HEAD(y); + list_splice_init(y,z); Signed-off-by: Christophe JAILLET --- net/rds/