Re: [PATCH] NET: SRv6: seg6_local: Fixed SRH processing when segments left is 0

2021-02-03 Thread Ahmed Abdelsalam
Hi Suprit, As you see the in the pseudocode, if Segments Left = 0, the End function will stop processing the SRH and will process upper layer protocols for OAM (e.g., ICMP). The packet will not be forwarded further. What you propose here is a different thing, you want to decap the SRv6 hea

Re: [PATCH] NET: SRv6: seg6_local: Fixed SRH processing when segments left is 0

2021-02-02 Thread Ahmed Abdelsalam
The current implementation is correct. This patch is introducing incorrect symantic to SRv6 End and End.T behaviors. SRv6 End and End.T behaviors (among other behaviors) are defined in the SRv6 Network Programming draft (Soon to published as an RFC) [1]. SRv6 End and End.T behaviors are used

Re: [PATCH] NET: SRv6: seg6_local: Fixed SRH processing when segments left is 0

2021-01-31 Thread David Ahern
[ cc David Lebrun, author of the original code ] On 1/31/21 6:08 AM, Suprit Japagal wrote: > From: "Suprit.Japagal" > > According to the standard IETF RFC 8754, section 4.3.1.1 > (https://tools.ietf.org/html/rfc8754#section-4.3.1.1) > When the segments left in SRH equals to 0, proceed to process

[PATCH] NET: SRv6: seg6_local: Fixed SRH processing when segments left is 0

2021-01-31 Thread Suprit Japagal
From: "Suprit.Japagal" According to the standard IETF RFC 8754, section 4.3.1.1 (https://tools.ietf.org/html/rfc8754#section-4.3.1.1) When the segments left in SRH equals to 0, proceed to process the next header in the packet, whose type is identified by the Next header field of the routing heade