Re: [PATCH] ISDN: eicon: message: remove redundant check

2018-03-30 Thread Gustavo A. R. Silva
On 03/30/2018 11:19 AM, Joe Perches wrote: On Fri, 2018-03-30 at 10:46 -0500, Gustavo A. R. Silva wrote: Check on plci->internal_command is unnecessary. Probably all of these are unnecessary too: $ for length in {7..2} ; do \ grep-2.5.4 -rP --include=*.[ch] -n "^\t{$length,$length}bre

Re: [PATCH] ISDN: eicon: message: remove redundant check

2018-03-30 Thread Joe Perches
On Fri, 2018-03-30 at 10:46 -0500, Gustavo A. R. Silva wrote: > Check on plci->internal_command is unnecessary. Probably all of these are unnecessary too: $ for length in {7..2} ; do \ grep-2.5.4 -rP --include=*.[ch] -n "^\t{$length,$length}break;\n\t{$(($length-1)),$(($length-1))}break;" *

[PATCH] ISDN: eicon: message: remove redundant check

2018-03-30 Thread Gustavo A. R. Silva
Check on plci->internal_command is unnecessary. Addresses-Coverity-ID: 1268778 ("Identical code for different branches") Signed-off-by: Gustavo A. R. Silva --- drivers/isdn/hardware/eicon/message.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/isdn/hardware/eicon/message.c b/driv