Re: [PATCH] IPv6: Fix NULL dereference in ipv6_del_addr()

2006-11-19 Thread David Miller
From: Ville Nuorvala <[EMAIL PROTECTED]> Date: Fri, 17 Nov 2006 21:27:21 +0200 > YOSHIFUJI Hideaki wrote: > > In article <[EMAIL PROTECTED]> (at Fri, 17 Nov 2006 15:26:28 +0200), Ville > > Nuorvala <[EMAIL PROTECTED]> says: > > > > > >> - dst_release(&rt->u.dst); > >> + if (rt

Re: [PATCH] IPv6: Fix NULL dereference in ipv6_del_addr()

2006-11-17 Thread Ville Nuorvala
YOSHIFUJI Hideaki wrote: In article <[EMAIL PROTECTED]> (at Fri, 17 Nov 2006 15:26:28 +0200), Ville Nuorvala <[EMAIL PROTECTED]> says: - dst_release(&rt->u.dst); + if (rt) + dst_release(&rt->u.dst); } I disagree. This does NOT fix a

Re: [PATCH] IPv6: Fix NULL dereference in ipv6_del_addr()

2006-11-17 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Fri, 17 Nov 2006 15:26:28 +0200), Ville Nuorvala <[EMAIL PROTECTED]> says: > - dst_release(&rt->u.dst); > + if (rt) > + dst_release(&rt->u.dst); > } I disagree. This does NOT fix any bugs. (void *)&rt->u.dst

[PATCH] IPv6: Fix NULL dereference in ipv6_del_addr()

2006-11-17 Thread Ville Nuorvala
>From 07ed0369cca6ef51013a63664b09ef402e79af9e Mon Sep 17 00:00:00 2001 From: Ville Nuorvala <[EMAIL PROTECTED]> Date: Fri, 17 Nov 2006 14:05:45 +0200 Subject: [PATCH] IPv6: Fix NULL dereference in ipv6_del_addr() Signed-off-by: Ville Nuorvala <[EMAIL PROTECTED]> --- net/ipv6/ad