From: Harald Welte <[EMAIL PROTECTED]>
Date: Mon, 8 Aug 2005 11:50:55 +0200
> DaveM is probably travelling back from UKUUG at the moment and therefore
> wasn't able to push this fix to you.
I'm actually back and operational as of this morning :-)
I'll push this stuff to Linus later today. So Li
Hi Linus!
DaveM is probably travelling back from UKUUG at the moment and therefore
wasn't able to push this fix to you.
The following trivial patch is confirmed to solve an ICMP corruption
problem if NAT and the NOTRACK target are used together.
Please apply before 2.6.13 is released.
Thanks,
[ Cleaning up Cc list ]
On Mon, Aug 08, 2005 at 12:34:00AM +0200, Patrick McHardy wrote:
> > Looking at the latest traces Vladimir sent me, there is another case,
> > too.
>
> Yes, but nat_packet checks if manips have actually been set up before
> touching the packet. This can never happen for t
Harald Welte wrote:
> On Sun, Aug 07, 2005 at 08:42:56PM +0200, Patrick McHardy wrote:
>
>>The conntrack reference is manually attached to locally generated ICMP
>>errors and icmp_reply_translation() doesn't check if NAT mappings have
>>been set up but simply replaces IP/port by what is stored in
On Sun, Aug 07, 2005 at 08:42:56PM +0200, Patrick McHardy wrote:
> Harald Welte wrote:
> > On Sun, Aug 07, 2005 at 05:18:06PM +0200, Harald Welte wrote:
> >
> >>The following trivial patch was confirmed to solve the problem. Patrick
> >>also has no objections, so please apply this to mainline.
>
Harald Welte wrote:
> On Sun, Aug 07, 2005 at 05:18:06PM +0200, Harald Welte wrote:
>
>>The following trivial patch was confirmed to solve the problem. Patrick
>>also has no objections, so please apply this to mainline.
>
> Please hold it back for another minute. I'm still puzzled by this
> pro
On Sun, Aug 07, 2005 at 06:44:15PM +0200, Harald Welte wrote:
> On Sun, Aug 07, 2005 at 05:18:06PM +0200, Harald Welte wrote:
> > Hi Dave!
> >
> > The following trivial patch was confirmed to solve the problem. Patrick
> > also has no objections, so please apply this to mainline.
>
> Please hold
On Sun, Aug 07, 2005 at 05:18:06PM +0200, Harald Welte wrote:
> Hi Dave!
>
> The following trivial patch was confirmed to solve the problem. Patrick
> also has no objections, so please apply this to mainline.
Please hold it back for another minute. I'm still puzzled by this
problem. I can neit
Hi Dave!
The following trivial patch was confirmed to solve the problem. Patrick
also has no objections, so please apply this to mainline.
I'm undecided whether it should go into 2.6.12.x, since the problem only
occurs in very rare usage cases. OTOTH, the fix is very trivial... so I
leave it up
