Re: [PATCH] Enable tx timestamping on loopback and dummy

2017-03-13 Thread Richard Cochran
On Sun, Mar 12, 2017 at 08:39:03PM +, Ezequiel Lara Gomez wrote: > On Sun, Mar 12, 2017 at 05:30:00PM +0100, Richard Cochran wrote: > > And while you are at it, explain why #1 is needed. > > Certainly - 2 (and 3) come from checkpatch.pl suggestions > (I'm mostly following through https://kern

Re: [PATCH] Enable tx timestamping on loopback and dummy

2017-03-12 Thread Ezequiel Lara Gomez
On Sun, Mar 12, 2017 at 05:30:00PM +0100, Richard Cochran wrote: > On Sun, Mar 12, 2017 at 12:17:30AM +0100, Oliver Hartkopp wrote: > > in fact you're doing three different things here: > > > > 1. introduce tx timestamping > > 2. silently change an include: -> > > 3. fix some whitespace and empt

Re: [PATCH] Enable tx timestamping on loopback and dummy

2017-03-12 Thread Richard Cochran
On Sun, Mar 12, 2017 at 12:17:30AM +0100, Oliver Hartkopp wrote: > in fact you're doing three different things here: > > 1. introduce tx timestamping > 2. silently change an include: -> > 3. fix some whitespace and empty line issues > > You'd better provide one patch for 1 & 2 and explain why 2

Re: [PATCH] Enable tx timestamping on loopback and dummy

2017-03-11 Thread Lara Gomez, Ezequiel
2 and 3 were recommendations by the checkpatch.pl script; as suggested, I've broken them down from the timestamping code and resubmitted as two separate patches (on separate emails though). > On 11 Mar 2017, at 23:17, Oliver Hartkopp wrote: > > Hi Ezequiel, > >> On 03/11/2017 03:42 PM, Ezequ

Re: [PATCH] Enable tx timestamping on loopback and dummy

2017-03-11 Thread Oliver Hartkopp
Hi Ezequiel, On 03/11/2017 03:42 PM, Ezequiel Lara Gomez wrote: Also, cleanup some warnings from timestamping code. in fact you're doing three different things here: 1. introduce tx timestamping 2. silently change an include: -> 3. fix some whitespace and empty line issues You'd better pro

[PATCH] Enable tx timestamping on loopback and dummy

2017-03-11 Thread Ezequiel Lara Gomez
This enables testing of SO_TIMESTAMPING options by targetting localhost addresses. Tested on qemu using txtimestamping.c from the kernel selftests. --- drivers/net/dummy.c| 1 + drivers/net/loopback.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/net/dummy.c b/drivers/net/dumm

Re: [PATCH] Enable tx timestamping on loopback and dummy

2017-03-11 Thread Soheil Hassas Yeganeh
On Sat, Mar 11, 2017 at 9:42 AM, Ezequiel Lara Gomez wrote: > Also, cleanup some warnings from timestamping code. Can you please submit the styling fixes as a separate patch? Thanks, Soheil

[PATCH] Enable tx timestamping on loopback and dummy

2017-03-11 Thread Ezequiel Lara Gomez
Also, cleanup some warnings from timestamping code. This enables testing of SO_TIMESTAMPING options by targetting localhost addresses. Tested on qemu using txtimestamping.c from the kernel selftests. Signed-off-by: Ezequiel Lara Gomez --- drivers/net/dummy.c| 1 + drivers/net/loopback.c |