Re: [PATCH] Create IP100A Driver

2006-08-02 Thread Jesse Huang
;Jesse Huang" <[EMAIL PROTECTED]> Cc: "John W. Linville" <[EMAIL PROTECTED]>; ; ; <[EMAIL PROTECTED]> Sent: Friday, July 28, 2006 6:14 PM Subject: Re: [PATCH] Create IP100A Driver Although it is occasionally OK to duplicate a driver, I do not see a compelling case wi

Re: [PATCH] Create IP100A Driver

2006-07-28 Thread Jeff Garzik
Jesse Huang wrote: Hi John: I will try mutt or mail when i want to send next patch. Most different of ip100a.c and sundance.c are almost same only fix some bugs. The different of ip100a and ip100 is in phy. We can use one driver to support those two device, I want to know what is better for kern

Re: [PATCH] Create IP100A Driver

2006-07-27 Thread Jesse Huang
]> To: "John W. Linville" <[EMAIL PROTECTED]> Cc: "Jesse Huang" <[EMAIL PROTECTED]>; ; ; <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]> Sent: Thursday, July 27, 2006 9:06 PM Subject: Re: [PATCH] Create IP100A Driver On Thu, Jul 27, 2006 at 08:54:27AM -0400, John

Re: [PATCH] Create IP100A Driver

2006-07-27 Thread Jesse Huang
suggestion, if you feel 1. was better for kernel. Jesse - Original Message - From: "John W. Linville" <[EMAIL PROTECTED]> To: "Jesse Huang" <[EMAIL PROTECTED]> Cc: ; ; <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]> Sent: Thursday, July 27, 2006 8:54

Re: [PATCH] Create IP100A Driver

2006-07-27 Thread Neil Horman
On Thu, Jul 27, 2006 at 08:54:27AM -0400, John W. Linville wrote: > On Thu, Jul 27, 2006 at 03:54:25PM -0400, Jesse Huang wrote: > > From: Jesse Huang <[EMAIL PROTECTED]> > > > > This is the first version of IP100A Linux Driver. > > One general comment is that your patch is whitespace-damaged, >

Re: [PATCH] Create IP100A Driver

2006-07-27 Thread John W. Linville
On Thu, Jul 27, 2006 at 03:54:25PM -0400, Jesse Huang wrote: > From: Jesse Huang <[EMAIL PROTECTED]> > > This is the first version of IP100A Linux Driver. One general comment is that your patch is whitespace-damaged, undoubtedly mangled by your mailer. I would suggest that you use a text- or cur

Re: [PATCH] Create IP100A Driver

2006-07-27 Thread Neil Horman
On Thu, Jul 27, 2006 at 03:54:25PM -0400, Jesse Huang wrote: > From: Jesse Huang <[EMAIL PROTECTED]> > > This is the first version of IP100A Linux Driver. > > Change Logs: > > --- > Thanks for the driver. Comments in line Regards Neil > +MODULE_PARM_DESC(debug, "IC+ IP100A debug level (0-5)