Re: [Devel] Re: [PATCH] Copy mac_len in skb_clone() as well

2007-03-15 Thread David Miller
From: Kirill Korotaev <[EMAIL PROTECTED]> Date: Thu, 15 Mar 2007 13:33:12 +0300 > David Miller wrote: > > From: Alexey Dobriyan <[EMAIL PROTECTED]> > > Date: Wed, 14 Mar 2007 16:07:11 +0300 > > > > > >>ANK says: "It is rarely used, that's wy it was not noticed. > >>But in the places, where it is

Re: [PATCH] Copy mac_len in skb_clone() as well

2007-03-15 Thread Alexey Kuznetsov
Hello! > What bug triggered that helped you discover this? Or is it > merely from a code audit? I asked the same question. :-) openvz added some another fields to skbuff and when it was found that they are lost while clone, he tried to figure out how all this works and looked for another exampl

Re: [Devel] Re: [PATCH] Copy mac_len in skb_clone() as well

2007-03-15 Thread Kirill Korotaev
David Miller wrote: > From: Alexey Dobriyan <[EMAIL PROTECTED]> > Date: Wed, 14 Mar 2007 16:07:11 +0300 > > >>ANK says: "It is rarely used, that's wy it was not noticed. >>But in the places, where it is used, it should be disaster." >> >>Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> > > >

Re: [PATCH] Copy mac_len in skb_clone() as well

2007-03-15 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Wed, 14 Mar 2007 16:07:11 +0300 > ANK says: "It is rarely used, that's wy it was not noticed. > But in the places, where it is used, it should be disaster." > > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied. What bug triggered that he

[PATCH] Copy mac_len in skb_clone() as well

2007-03-14 Thread Alexey Dobriyan
ANK says: "It is rarely used, that's wy it was not noticed. But in the places, where it is used, it should be disaster." Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> --- net/core/skbuff.c |1 + 1 file changed, 1 insertion(+) --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -463,6 +4