Re: [PATCH] Bluetooth: smp: Fix biased random passkey generation

2020-12-07 Thread kernel test robot
Hi Mincheol, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on bluetooth-next/master] [also build test WARNING on net-next/master net/master bluetooth/master sparc-next/master v5.10-rc7 next-20201207] [If your patch is applied to the wrong git tree, kindly drop u

[PATCH] Bluetooth: smp: Fix biased random passkey generation

2020-12-07 Thread Mincheol Son
Since u32 range size is not a multiple of 1,000,000, current passkey generation logic is biased. Fixed this by adding a routine that selects passkey again if passkey is 4,200,000,000 or more. Signed-off-by: Mincheol Son --- net/bluetooth/smp.c | 4 +++- 1 file changed, 3 insertions(+), 1 dele