Re: [PATCH] Add Broadcom PHY support

2006-12-05 Thread Andy Fleming
On Dec 5, 2006, at 00:03, Benjamin Herrenschmidt wrote: I believe that this fiber enabling can be done by defining config_init in the phy_driver struct. struct phy_driver { /* Called to initialize the PHY, * including after a reset */ int (*config_init)(struct phy

Re: [PATCH] Add Broadcom PHY support

2006-12-04 Thread Benjamin Herrenschmidt
> I believe that this fiber enabling can be done by defining config_init in the > phy_driver struct. > > struct phy_driver { > > /* Called to initialize the PHY, >* including after a reset */ > int (*config_init)(struct phy_device *phydev); > > }; Well... I don't know fo

Re: [PATCH] Add Broadcom PHY support

2006-12-04 Thread Amy Fong
> On Fri, 2006-09-15 at 16:15 -0400, Amy Fong wrote: > > [PATCH] Add Broadcom PHY support > > > > This patch adds a driver to support the bcm5421s and bcm5461s PHY > > > > Kernel version: linux-2.6.18-rc6 > > > > Signed-off-by: Amy Fong >

Re: [PATCH] Add Broadcom PHY support

2006-12-04 Thread Benjamin Herrenschmidt
On Fri, 2006-09-15 at 16:15 -0400, Amy Fong wrote: > [PATCH] Add Broadcom PHY support > > This patch adds a driver to support the bcm5421s and bcm5461s PHY > > Kernel version: linux-2.6.18-rc6 > > Signed-off-by: Amy Fong Some 5421's need special initialisation (se

Re: [PATCH] Add Broadcom PHY support

2006-09-19 Thread Maciej W. Rozycki
On Tue, 19 Sep 2006, Jeff Garzik wrote: > > And sb1250-mac.c would be happy to use it too. > > "would be happy to" != "is using". I don't want to add a phy driver until > there are already active users in the kernel. Fair enough, but Amy may be looking forward to seeing yet another piece of

Re: [PATCH] Add Broadcom PHY support

2006-09-19 Thread Jeff Garzik
Maciej W. Rozycki wrote: On Tue, 19 Sep 2006, Amy Fong wrote: And... where are the users of this phy driver? [...] This phy driver is used by the WRS's sbc8560 (bcm5421s) and sbc843x (bcm5461s) via the gianfar driver. And sb1250-mac.c would be happy to use it too. "would be happy to" !=

Re: [PATCH] Add Broadcom PHY support

2006-09-19 Thread Maciej W. Rozycki
On Tue, 19 Sep 2006, Amy Fong wrote: > > And... where are the users of this phy driver? [...] > This phy driver is used by the WRS's sbc8560 (bcm5421s) and sbc843x > (bcm5461s) via the gianfar driver. And sb1250-mac.c would be happy to use it too. Maciej - To unsubscribe from this list: send

Re: [PATCH] Add Broadcom PHY support

2006-09-19 Thread Amy Fong
[ Charset ISO-8859-1 unsupported, converting... ] > Amy Fong wrote: > > [PATCH] Add Broadcom PHY support > > > > This patch adds a driver to support the bcm5421s and bcm5461s PHY > > > > Kernel version: linux-2.6.18-rc6 > > > > Signed-off-by: Amy F

Re: [PATCH] Add Broadcom PHY support

2006-09-18 Thread Jeff Garzik
Amy Fong wrote: [PATCH] Add Broadcom PHY support This patch adds a driver to support the bcm5421s and bcm5461s PHY Kernel version: linux-2.6.18-rc6 Signed-off-by: Amy Fong <[EMAIL PROTECTED]> And... where are the users of this phy driver? Jeff - To unsubscribe from thi

[PATCH] Add Broadcom PHY support

2006-09-15 Thread Amy Fong
[PATCH] Add Broadcom PHY support This patch adds a driver to support the bcm5421s and bcm5461s PHY Kernel version: linux-2.6.18-rc6 Signed-off-by: Amy Fong <[EMAIL PROTECTED]> Index: linux-2.6.18-rc6/drivers/net/phy/broa