Hi Jon,
Jon Paul Maloy schrieb:
> Ingo Oeser wrote:
> > static inlinevoid msg_set_bits(struct tipc_msg *m, u32 w,
> > u32 pos, __be32 mask, __be32 val)
> >
> >
> > Care to resubmit?
> I don't mind at all, but I would first like to understand better
> what this means.
Hi Jon,
Jon Paul Maloy schrieb:
> 2) The code has been optimized to minimize the number of run-time
>endianness conversion operations by leveraging the fact that the
>mask (and, in some cases, the value as well) is constant and the
>necessary conversion can be performed by the compiler
This patch makes two enhancements to msg_set_bits():
1) It now ignores any bits of the new field value that are not
covered by the mask being used. (Previously, if the new value
exceeded the size of the mask the extra bits could corrupt
other fields in the message header word being updated
From: Jon Paul Maloy <[EMAIL PROTECTED]>
Date: Tue, 24 Apr 2007 13:21:40 -0400
> This patch makes two enhancements to msg_set_bits():
Applied, thanks a lot.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at ht
This patch makes two enhancements to msg_set_bits():
1) It now ignores any bits of the new field value that are not
covered by the mask being used. (Previously, if the new value
exceeded the size of the mask the extra bits could corrupt
other fields in the message header word being updated
