Re: [PATCH] [SIS190] Constify data marked as __devinitdata

2008-01-30 Thread Sam Ravnborg
On Wed, Jan 30, 2008 at 02:31:05PM +0100, Jan Engelhardt wrote: > > On Jan 30 2008 12:25, Sam Ravnborg wrote: > > > >We have just introduced __initconst, __cpuinitconst, __meminitconst > >for const data. > >So the patch is wrong. > > Oh joy, more tags. Is it actually possible to combine const > w

Re: [PATCH] [SIS190] Constify data marked as __devinitdata

2008-01-30 Thread Jan Engelhardt
On Jan 30 2008 12:25, Sam Ravnborg wrote: > >We have just introduced __initconst, __cpuinitconst, __meminitconst >for const data. >So the patch is wrong. Oh joy, more tags. Is it actually possible to combine const with __devinitconst now? static const uint16_t foo[] __devinitconst = { ... }; --

Re: [PATCH] [SIS190] Constify data marked as __devinitdata

2008-01-30 Thread Jonas Bonn
instead? Because AFAIK, const *and* __sectionmarker does not mix. > You're right... it's documented in linux/init.h that const and __sectionmarker do not mix. The compile error is due to the use of const and __section marker in the function sis190_get_mac_addr_from_apc(). -- To unsubscribe

Re: [PATCH] [SIS190] Constify data marked as __devinitdata

2008-01-30 Thread Sam Ravnborg
On Wed, Jan 30, 2008 at 12:23:23PM +0100, Jan Engelhardt wrote: > > On Jan 30 2008 11:53, Jonas Bonn wrote: > > > >This fixes build error as gcc complains about a "section type conflict" > >due to the const __devinitdata in sis190_get_mac_addr_from_apc(). > > >-static struct pci_device_id sis190_

Re: [PATCH] [SIS190] Constify data marked as __devinitdata

2008-01-30 Thread Jan Engelhardt
On Jan 30 2008 11:53, Jonas Bonn wrote: > >This fixes build error as gcc complains about a "section type conflict" >due to the const __devinitdata in sis190_get_mac_addr_from_apc(). >-static struct pci_device_id sis190_pci_tbl[] __devinitdata = { >+static const struct pci_device_id sis190_pci_tbl

[PATCH] [SIS190] Constify data marked as __devinitdata

2008-01-30 Thread Jonas Bonn
This fixes build error as gcc complains about a "section type conflict" due to the const __devinitdata in sis190_get_mac_addr_from_apc(). --- drivers/net/sis190.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/sis190.c b/drivers/net/sis190.c index b570402..e4