Re: [PATCH] [PATCH bpf] style fix in while(!feof()) loop

2019-05-28 Thread Daniel Borkmann
On 05/26/2019 12:32 PM, Chang-Hsien Tsai wrote: > use fgets() as the while loop condition. > > Signed-off-by: Chang-Hsien Tsai Applied, thanks!

Re: [PATCH] [PATCH bpf] style fix in while(!feof()) loop

2019-05-27 Thread Y Song
On Sun, May 26, 2019 at 3:35 AM Chang-Hsien Tsai wrote: > > use fgets() as the while loop condition. > > Signed-off-by: Chang-Hsien Tsai Looks like right now we did not really differentiate error in fgets from EOF, so the change is in this patch is equivalent to its previous behavior. Acked-by:

[PATCH] [PATCH bpf] style fix in while(!feof()) loop

2019-05-26 Thread Chang-Hsien Tsai
use fgets() as the while loop condition. Signed-off-by: Chang-Hsien Tsai --- tools/bpf/bpftool/xlated_dumper.c | 4 +--- tools/testing/selftests/bpf/trace_helpers.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/tools/bpf/bpftool/xlated_dumper.c b/tools/bpf/b