Re: [PATCH] netfilter: x_tables: add xt_tunnel match

2019-01-09 Thread wenxu
On 1/10/2019 12:05 PM, wenxu wrote: > On 1/10/2019 12:41 AM, Pablo Neira Ayuso wrote: >> On Fri, Dec 21, 2018 at 06:12:24PM +0800, we...@ucloud.cn wrote: >> [...] >>> +static struct xt_match tunnel_mt_reg __read_mostly = { >>> + .name = "tunnel", >>> + .revision = 0, >>> + .

Re: [PATCH] netfilter: x_tables: add xt_tunnel match

2019-01-09 Thread wenxu
On 1/10/2019 12:41 AM, Pablo Neira Ayuso wrote: > On Fri, Dec 21, 2018 at 06:12:24PM +0800, we...@ucloud.cn wrote: > [...] >> +static struct xt_match tunnel_mt_reg __read_mostly = { >> +.name = "tunnel", >> +.revision = 0, >> +.family = NFPROTO_UNSPEC, >> +

Re: [PATCH] netfilter: x_tables: add xt_tunnel match

2019-01-09 Thread Pablo Neira Ayuso
On Fri, Dec 21, 2018 at 06:12:24PM +0800, we...@ucloud.cn wrote: [...] > +static struct xt_match tunnel_mt_reg __read_mostly = { > + .name = "tunnel", > + .revision = 0, > + .family = NFPROTO_UNSPEC, > + .match = tunnel_mt, > + .matchsize =

Re: [PATCH] netfilter: x_tables: add xt_tunnel match

2019-01-08 Thread wenxu
Hi pablo, How about the state for this patch? On 12/21/2018 6:12 PM, we...@ucloud.cn wrote: > From: wenxu > > This patch allows us to match on the tunnel metadata that is available > of the packet. We can use this to validate if the packet comes from/goes > to tunnel and the corresponding tunne

[PATCH] netfilter: x_tables: add xt_tunnel match

2018-12-21 Thread wenxu
From: wenxu This patch allows us to match on the tunnel metadata that is available of the packet. We can use this to validate if the packet comes from/goes to tunnel and the corresponding tunnel ID in the iptables. Signed-off-by: wenxu --- include/uapi/linux/netfilter/xt_tunnel.h | 13 +++

Re: [PATCH] netfilter: x_tables: simplify IS_ERR_OR_NULL to NULL test

2016-11-13 Thread Pablo Neira Ayuso
On Fri, Nov 11, 2016 at 01:32:38PM +0100, Julia Lawall wrote: > Since commit 7926dbfa4bc1 ("netfilter: don't use > mutex_lock_interruptible()"), the function xt_find_table_lock can only > return NULL on an error. Simplify the call sites and update the > comment before the function. Applied, thank

[PATCH] netfilter: x_tables: simplify IS_ERR_OR_NULL to NULL test

2016-11-11 Thread Julia Lawall
Since commit 7926dbfa4bc1 ("netfilter: don't use mutex_lock_interruptible()"), the function xt_find_table_lock can only return NULL on an error. Simplify the call sites and update the comment before the function. The semantic patch that change the code is as follows: (http://coccinelle.lip6.fr/)

Re: [PATCH] netfilter: x_tables: fix kmemcheck warning.

2016-07-24 Thread Sergei Shtylyov
Hello. On 7/24/2016 5:31 AM, Tetsuo Handa wrote: kmemcheck complains that some of struct nf_hook_ops members allocated at xt_hook_ops_alloc() are not initialized before nf_register_net_hook() is called. Add __GFP_ZERO to initialize explicitly. [ 367.411936] nf_conntrack version 0.5.0 (6144 bu

[PATCH] netfilter: x_tables: fix kmemcheck warning.

2016-07-23 Thread Tetsuo Handa
kmemcheck complains that some of struct nf_hook_ops members allocated at xt_hook_ops_alloc() are not initialized before nf_register_net_hook() is called. Add __GFP_ZERO to initialize explicitly. [ 367.411936] nf_conntrack version 0.5.0 (6144 buckets, 24576 max) [ 367.458540] ip_tables: (C) 2000-

Re: [PATCH] [NETFILTER] x_tables

2006-01-13 Thread David S. Miller
From: Harald Welte <[EMAIL PROTECTED]> Date: Thu, 12 Jan 2006 21:47:34 +0100 > Finally, I included all the suggestions/comments for x_tables "take 5", > ran the nfsim testsuite and feel confident that this is ready for prime > time. > > Please apply this huge one for 2.6.16, It's been in my tree