Re: [PATCH] [NET]: fix multicast list when cloning sockets

2007-08-24 Thread David Miller
From: Flavio Leitner <[EMAIL PROTECTED]> Date: Tue, 31 Jul 2007 15:29:40 -0300 > On Tue, Jul 31, 2007 at 12:00:41AM -0300, Arnaldo Carvalho de Melo wrote: > > On 7/30/07, David Miller <[EMAIL PROTECTED]> wrote: > > > Allowing non-datagram sockets to end up with a non-NULL inet->mc_list > > > in th

Re: [PATCH] [NET]: fix multicast list when cloning sockets

2007-07-31 Thread Flavio Leitner
On Tue, Jul 31, 2007 at 12:00:41AM -0300, Arnaldo Carvalho de Melo wrote: > On 7/30/07, David Miller <[EMAIL PROTECTED]> wrote: > > Allowing non-datagram sockets to end up with a non-NULL inet->mc_list > > in the first place is a bug. > > > > Multicast subscriptions cannot even be used with TCP and

Re: [PATCH] [NET]: fix multicast list when cloning sockets

2007-07-30 Thread Arnaldo Carvalho de Melo
On 7/30/07, David Miller <[EMAIL PROTECTED]> wrote: > From: Flavio Leitner <[EMAIL PROTECTED]> > Date: Mon, 30 Jul 2007 13:04:48 -0300 > > > > > The sock_copy() function uses memcpy() to clone the socket > > including the struct ip_mc_socklist *mc_list pointer. > > > > The ip_mc_drop_socket() funct

Re: [PATCH] [NET]: fix multicast list when cloning sockets

2007-07-30 Thread David Miller
From: Flavio Leitner <[EMAIL PROTECTED]> Date: Mon, 30 Jul 2007 13:04:48 -0300 > > The sock_copy() function uses memcpy() to clone the socket > including the struct ip_mc_socklist *mc_list pointer. > > The ip_mc_drop_socket() function is called when socket is closed > to free these objects leavi

[PATCH] [NET]: fix multicast list when cloning sockets

2007-07-30 Thread Flavio Leitner
The sock_copy() function uses memcpy() to clone the socket including the struct ip_mc_socklist *mc_list pointer. The ip_mc_drop_socket() function is called when socket is closed to free these objects leaving the other sockets cloned from the same master socket with invalid pointers. This patch s