Re: [PATCH] [ATM] he: Fix __init/__devinit conflict

2006-09-25 Thread chas williams - CONTRACTOR
In message <[EMAIL PROTECTED]>,David Miller writes: >Chas, as a subsystem maintainer, if you change a submitter's patch in >a significant and non-trivial way, you should at least mention a brief >reason why you did that. In this case, why did you delete all of >Roland's __init/__devinit transforma

Re: [PATCH] [ATM] he: Fix __init/__devinit conflict

2006-09-24 Thread Roland Dreier
David> I was waiting for a resolution in the fact that the copy David> Chas posted only had one of the transformations whereas as David> you pointed out all of the ones in your original patch were David> necessary. Actually I think there was some confusion because akpm forwarded a

Re: [PATCH] [ATM] he: Fix __init/__devinit conflict

2006-09-24 Thread David Miller
From: Roland Dreier <[EMAIL PROTECTED]> Date: Sat, 23 Sep 2006 17:17:54 -0700 > Dave, this was acked by Chas (and he even requested it go into 2.6.18) > but it seems to have gotten dropped somewhere -- it's not in Linus's > tree even after he pulled your net tree. > > Please apply. Applied. I w

Re: [PATCH] [ATM] he: Fix __init/__devinit conflict

2006-09-23 Thread Roland Dreier
he_init_one() is declared __devinit, but calls lots of init functions that are marked __init. However, if CONFIG_HOTPLUG is enabled, __devinit functions go into normal .text, which leads to WARNING: drivers/atm/he.o - Section mismatch: reference to .init.text: from .text between 'he_start' (

[PATCH] [ATM] he: Fix __init/__devinit conflict

2006-09-11 Thread Roland Dreier
he_init_one() is declared __devinit, but calls lots of init functions that are marked __init. However, if CONFIG_HOTPLUG is enabled, __devinit functions go into normal .text, which leads to WARNING: drivers/atm/he.o - Section mismatch: reference to .init.text: from .text between 'he_start' (