Re: [PATCH] [-MM, FIX V3] e1000e: incorporate napi_struct changes from net-2.6.24.git

2007-09-12 Thread David Miller
From: "Kok, Auke" <[EMAIL PROTECTED]> Date: Wed, 12 Sep 2007 09:42:29 -0700 > David Miller wrote: > > > > diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c > > index 7b0bcdb..58bb758 100644 > > --- a/drivers/net/e1000/e1000_main.c > > +++ b/drivers/net/e1000/e1000_main.

Re: [PATCH] [-MM, FIX V3] e1000e: incorporate napi_struct changes from net-2.6.24.git

2007-09-12 Thread Kok, Auke
David Miller wrote: From: Robert Olsson <[EMAIL PROTECTED]> Date: Sat, 8 Sep 2007 09:53:49 +0200 Yes a correct observation. I've spotted this bug too and it caused by the policy change in the NAPI scheduling. Look at tx_cleaned. I suggest we revert this change for now. The tx_cleaned lo

Re: [PATCH] [-MM, FIX V3] e1000e: incorporate napi_struct changes from net-2.6.24.git

2007-09-12 Thread David Miller
From: Robert Olsson <[EMAIL PROTECTED]> Date: Sat, 8 Sep 2007 09:53:49 +0200 > Yes a correct observation. I've spotted this bug too and it caused by the > policy change in the NAPI scheduling. Look at tx_cleaned. > > I suggest we revert this change for now. The tx_cleaned logic change was n

Re: [PATCH] [-MM, FIX V3] e1000e: incorporate napi_struct changes from net-2.6.24.git

2007-09-08 Thread Robert Olsson
Kok, Auke writes: > david, > > while testing this patch I noticed that the poll routine is now called > 100% of the time, and since I'm not doing much different than before, I > suspec that something in the new napi code is staying in polling mode > forever? Since e1000e is pretty much t

Re: [PATCH] [-MM, FIX V3] e1000e: incorporate napi_struct changes from net-2.6.24.git

2007-09-07 Thread Kok, Auke
Auke Kok wrote: This incorporates the new napi_struct changes into e1000e. Included bugfix for ifdown hang from Krishna Kumar for e1000. Disabling polling is no longer needed at init time, so remove napi_disable() call from _probe(). david, while testing this patch I noticed that the poll ro

[PATCH] [-MM, FIX V3] e1000e: incorporate napi_struct changes from net-2.6.24.git

2007-09-07 Thread Auke Kok
This incorporates the new napi_struct changes into e1000e. Included bugfix for ifdown hang from Krishna Kumar for e1000. Disabling polling is no longer needed at init time, so remove napi_disable() call from _probe(). Signed-off-by: Auke Kok <[EMAIL PROTECTED]> --- drivers/net/e1000e/e1000.h |