Re: [PATCH][next] xsk: Fix null check on error return path

2020-09-02 Thread Gustavo A. R. Silva
On Wed, Sep 02, 2020 at 08:33:41PM +0200, Daniel Borkmann wrote: > On 9/2/20 5:07 PM, Gustavo A. R. Silva wrote: > > Currently, dma_map is being checked, when the right object identifier > > to be null-checked is dma_map->dma_pages, instead. > > > > Fix this by null-checking dma_map->dma_pages. >

Re: [PATCH][next] xsk: Fix null check on error return path

2020-09-02 Thread Daniel Borkmann
On 9/2/20 5:07 PM, Gustavo A. R. Silva wrote: Currently, dma_map is being checked, when the right object identifier to be null-checked is dma_map->dma_pages, instead. Fix this by null-checking dma_map->dma_pages. Addresses-Coverity-ID: 1496811 ("Logically dead code") Fixes: 921b68692abb ("xsk:

Re: [PATCH][next] xsk: Fix null check on error return path

2020-09-02 Thread Gustavo A. R. Silva
On Wed, Sep 02, 2020 at 05:12:51PM +0200, Björn Töpel wrote: > On 2020-09-02 17:07, Gustavo A. R. Silva wrote: > > Currently, dma_map is being checked, when the right object identifier > > to be null-checked is dma_map->dma_pages, instead. > > > > Fix this by null-checking dma_map->dma_pages. > >

[PATCH][next] xsk: Fix null check on error return path

2020-09-02 Thread Gustavo A. R. Silva
Currently, dma_map is being checked, when the right object identifier to be null-checked is dma_map->dma_pages, instead. Fix this by null-checking dma_map->dma_pages. Addresses-Coverity-ID: 1496811 ("Logically dead code") Fixes: 921b68692abb ("xsk: Enable sharing of dma mappings") Signed-off-by:

Re: [PATCH][next] xsk: Fix null check on error return path

2020-09-02 Thread Björn Töpel
On 2020-09-02 17:07, Gustavo A. R. Silva wrote: Currently, dma_map is being checked, when the right object identifier to be null-checked is dma_map->dma_pages, instead. Fix this by null-checking dma_map->dma_pages. Addresses-Coverity-ID: 1496811 ("Logically dead code") Fixes: 921b68692abb ("xsk