Re: [PATCH][next] ixgbe: fix comparison of offset with zero or NVM_INVALID_PTR

2018-01-12 Thread Jeff Kirsher
On Fri, 2018-01-12 at 17:13 +, Colin King wrote: > From: Colin Ian King > > The incorrect operator && is being used and will always return false > as offset can never be two different values at the same time. Fix > this > by using the || operator instead. > > Detected by CoverityScan, CID#14

[PATCH][next] ixgbe: fix comparison of offset with zero or NVM_INVALID_PTR

2018-01-12 Thread Colin King
From: Colin Ian King The incorrect operator && is being used and will always return false as offset can never be two different values at the same time. Fix this by using the || operator instead. Detected by CoverityScan, CID#1463806 ("Logically dead code") Fixes: 73834aec7199 ("ixgbe: extend fi