Re: [PATCH][net-next] net: bridge: remove redundant check to see if err is set

2017-02-07 Thread David Miller
From: Colin King Date: Tue, 7 Feb 2017 10:56:38 + > From: Colin Ian King > > The error check on err is redundant as it is being checked > previously each time it has been updated. Remove this redundant > check. > > Detected with CoverityScan, CID#140030("Logically dead code") > > Signed

Re: [PATCH][net-next] net: bridge: remove redundant check to see if err is set

2017-02-07 Thread Colin Ian King
..and one more thing, in net/bridge/br_netlink_tunnel.c, __get_num_vlan_tunnel_infos, are the args to vlan_tunnel_id_isrange() the wrong way around? I'm not 100% sure, but I'd thought I'd flag it up. if (v_start) { if ((v_end->vid - v->vid) > 0 && vlan_

Re: [PATCH][net-next] net: bridge: remove redundant check to see if err is set

2017-02-07 Thread Nikolay Aleksandrov
On 07/02/17 11:56, Colin King wrote: > From: Colin Ian King > > The error check on err is redundant as it is being checked > previously each time it has been updated. Remove this redundant > check. > > Detected with CoverityScan, CID#140030("Logically dead code") > > Signed-off-by: Colin Ian K

[PATCH][net-next] net: bridge: remove redundant check to see if err is set

2017-02-07 Thread Colin King
From: Colin Ian King The error check on err is redundant as it is being checked previously each time it has been updated. Remove this redundant check. Detected with CoverityScan, CID#140030("Logically dead code") Signed-off-by: Colin Ian King --- net/bridge/br_netlink.c | 3 --- 1 file chang