Re: [PATCH][VLAN] Merge tree equal tails in vlan_skb_recv

2008-01-09 Thread Patrick McHardy
Pavel Emelyanov wrote: Hi, Patrick. Pavel Emelyanov wrote: There are tree paths in it, that set the skb->proto and then perform common receive manipulations (basically call netif_rx()). I think, that we can make this code flow easier to understand by introducing the vlan_set_encap_proto() fun

Re: [PATCH][VLAN] Merge tree equal tails in vlan_skb_recv

2008-01-09 Thread Pavel Emelyanov
Hi, Patrick. > Pavel Emelyanov wrote: >> There are tree paths in it, that set the skb->proto and then >> perform common receive manipulations (basically call netif_rx()). >> >> I think, that we can make this code flow easier to understand >> by introducing the vlan_set_encap_proto() function (I ho

Re: [PATCH][VLAN] Merge tree equal tails in vlan_skb_recv

2007-12-07 Thread Patrick McHardy
Pavel Emelyanov wrote: There are tree paths in it, that set the skb->proto and then perform common receive manipulations (basically call netif_rx()). I think, that we can make this code flow easier to understand by introducing the vlan_set_encap_proto() function (I hope the name is good) to set

[PATCH][VLAN] Merge tree equal tails in vlan_skb_recv

2007-12-07 Thread Pavel Emelyanov
There are tree paths in it, that set the skb->proto and then perform common receive manipulations (basically call netif_rx()). I think, that we can make this code flow easier to understand by introducing the vlan_set_encap_proto() function (I hope the name is good) to setup the skb proto and merg