Re: [PATCH][V2] ipv6: fix incorrect bitwise operator used on rt6i_flags

2017-10-10 Thread David Miller
From: Wei Wang Date: Tue, 10 Oct 2017 11:38:20 -0700 > On Tue, Oct 10, 2017 at 11:10 AM, Colin King wrote: >> From: Colin Ian King >> >> The use of the | operator always leads to true which looks rather >> suspect to me. Fix this by using & instead to just check the >> RTF_CACHE entry bit. >> >

Re: [PATCH][V2] ipv6: fix incorrect bitwise operator used on rt6i_flags

2017-10-10 Thread Martin KaFai Lau
On Tue, Oct 10, 2017 at 06:10:30PM +, Colin King wrote: > From: Colin Ian King > > The use of the | operator always leads to true which looks rather > suspect to me. Fix this by using & instead to just check the > RTF_CACHE entry bit. > > Detected by CoverityScan, CID#1457734, #1457747 ("Wro

Re: [PATCH][V2] ipv6: fix incorrect bitwise operator used on rt6i_flags

2017-10-10 Thread Wei Wang
On Tue, Oct 10, 2017 at 11:10 AM, Colin King wrote: > From: Colin Ian King > > The use of the | operator always leads to true which looks rather > suspect to me. Fix this by using & instead to just check the > RTF_CACHE entry bit. > > Detected by CoverityScan, CID#1457734, #1457747 ("Wrong operat

[PATCH][V2] ipv6: fix incorrect bitwise operator used on rt6i_flags

2017-10-10 Thread Colin King
From: Colin Ian King The use of the | operator always leads to true which looks rather suspect to me. Fix this by using & instead to just check the RTF_CACHE entry bit. Detected by CoverityScan, CID#1457734, #1457747 ("Wrong operator used") Fixes: 35732d01fe31 ("ipv6: introduce a hash table to