Re: [PATCH][RFC] network splice receive v2

2007-06-15 Thread Jens Axboe
On Fri, Jun 15 2007, Evgeniy Polyakov wrote: > On Fri, Jun 15, 2007 at 11:34:30AM +0200, Jens Axboe ([EMAIL PROTECTED]) > wrote: > > > Both spd->nr_pages and page_nr are equal to 1. When spd->nr_pages > > > was 2 there was only 1 free slot in pipe_buffer. > > > > Ah duh, indeed, it is a dumb bug

Re: [PATCH][RFC] network splice receive v2

2007-06-15 Thread Evgeniy Polyakov
On Fri, Jun 15, 2007 at 11:34:30AM +0200, Jens Axboe ([EMAIL PROTECTED]) wrote: > > Both spd->nr_pages and page_nr are equal to 1. When spd->nr_pages > > was 2 there was only 1 free slot in pipe_buffer. > > Ah duh, indeed, it is a dumb bug indeed. This should work. Yep, this one works too. > dif

Re: [PATCH][RFC] network splice receive v2

2007-06-15 Thread Jens Axboe
On Fri, Jun 15 2007, Evgeniy Polyakov wrote: > On Fri, Jun 15, 2007 at 10:43:18AM +0200, Jens Axboe ([EMAIL PROTECTED]) > wrote: > > > So, things turned down to be not in the __splice_from_pipe(), but > > > splice_to_pipe(). Attached patch fixes a leak for me. > > > It was tested with different da

Re: [PATCH][RFC] network splice receive v2

2007-06-15 Thread Evgeniy Polyakov
On Fri, Jun 15, 2007 at 10:43:18AM +0200, Jens Axboe ([EMAIL PROTECTED]) wrote: > > So, things turned down to be not in the __splice_from_pipe(), but > > splice_to_pipe(). Attached patch fixes a leak for me. > > It was tested with different data files and all were received correctly. > > > > Signe

Re: [PATCH][RFC] network splice receive v2

2007-06-15 Thread Jens Axboe
On Fri, Jun 15 2007, Evgeniy Polyakov wrote: > On Thu, Jun 14, 2007 at 01:59:02PM +0200, Jens Axboe ([EMAIL PROTECTED]) > wrote: > > On Thu, Jun 14 2007, Evgeniy Polyakov wrote: > > > On Wed, Jun 13, 2007 at 12:01:04PM +0400, Evgeniy Polyakov ([EMAIL > > > PROTECTED]) wrote: > > > > I will rebase

Re: [PATCH][RFC] network splice receive v2

2007-06-15 Thread Evgeniy Polyakov
On Thu, Jun 14, 2007 at 01:59:02PM +0200, Jens Axboe ([EMAIL PROTECTED]) wrote: > On Thu, Jun 14 2007, Evgeniy Polyakov wrote: > > On Wed, Jun 13, 2007 at 12:01:04PM +0400, Evgeniy Polyakov ([EMAIL > > PROTECTED]) wrote: > > > I will rebase my tree, likely something was not merged correctly. > >

Re: [PATCH][RFC] network splice receive v2

2007-06-14 Thread Jens Axboe
On Thu, Jun 14 2007, Evgeniy Polyakov wrote: > On Wed, Jun 13, 2007 at 12:01:04PM +0400, Evgeniy Polyakov ([EMAIL > PROTECTED]) wrote: > > I will rebase my tree, likely something was not merged correctly. > > Ok, I've just rebased a tree from recent git and pulled from brick - > things seems to b

Re: [PATCH][RFC] network splice receive v2

2007-06-14 Thread Evgeniy Polyakov
On Wed, Jun 13, 2007 at 12:01:04PM +0400, Evgeniy Polyakov ([EMAIL PROTECTED]) wrote: > I will rebase my tree, likely something was not merged correctly. Ok, I've just rebased a tree from recent git and pulled from brick - things seems to be settled. I've ran several tests with different filesize

Re: [PATCH][RFC] network splice receive v2

2007-06-13 Thread Jens Axboe
On Wed, Jun 13 2007, Evgeniy Polyakov wrote: > On Tue, Jun 12, 2007 at 08:17:32PM +0200, Jens Axboe ([EMAIL PROTECTED]) > wrote: > > On Tue, Jun 12 2007, Evgeniy Polyakov wrote: > > > On Mon, Jun 11, 2007 at 01:59:26PM +0200, Jens Axboe ([EMAIL PROTECTED]) > > > wrote: > > > > Patches are against

Re: [PATCH][RFC] network splice receive v2

2007-06-13 Thread Evgeniy Polyakov
On Tue, Jun 12, 2007 at 08:17:32PM +0200, Jens Axboe ([EMAIL PROTECTED]) wrote: > On Tue, Jun 12 2007, Evgeniy Polyakov wrote: > > On Mon, Jun 11, 2007 at 01:59:26PM +0200, Jens Axboe ([EMAIL PROTECTED]) > > wrote: > > > Patches are against the #splice branch of the block repo, "official" url > >

Re: [PATCH][RFC] network splice receive v2

2007-06-12 Thread Jens Axboe
On Tue, Jun 12 2007, Evgeniy Polyakov wrote: > On Mon, Jun 11, 2007 at 01:59:26PM +0200, Jens Axboe ([EMAIL PROTECTED]) > wrote: > > Patches are against the #splice branch of the block repo, "official" url > > of that is: > > > > git://git.kernel.dk/data/git/linux-2.6-block.git/ > > > > and it's

Re: [PATCH][RFC] network splice receive v2

2007-06-12 Thread Jens Axboe
On Tue, Jun 12 2007, Jens Axboe wrote: > On Tue, Jun 12 2007, Evgeniy Polyakov wrote: > > On Mon, Jun 11, 2007 at 01:59:26PM +0200, Jens Axboe ([EMAIL PROTECTED]) > > wrote: > > > Patches are against the #splice branch of the block repo, "official" url > > > of that is: > > > > > > git://git.kern

Re: [PATCH][RFC] network splice receive v2

2007-06-12 Thread Evgeniy Polyakov
On Mon, Jun 11, 2007 at 01:59:26PM +0200, Jens Axboe ([EMAIL PROTECTED]) wrote: > Patches are against the #splice branch of the block repo, "official" url > of that is: > > git://git.kernel.dk/data/git/linux-2.6-block.git/ > > and it's based on Linus main tree. Let me know if I should supply netd

[PATCH][RFC] network splice receive v2

2007-06-11 Thread Jens Axboe
Hi, Here's an updated implementation of tcp network splice receive support. It actually works for me now, no data corruption seen. For the original announcement and how to test it, see: http://marc.info/?l=linux-netdev&m=118103093400770&w=2 I hang on to the original skb by creating a clone of i