Re: [PATCH][AX25] ax25_ds_timer: use mod_timer instead of add_timer

2008-02-11 Thread David Miller
From: Jarek Poplawski <[EMAIL PROTECTED]> Date: Wed, 6 Feb 2008 09:14:13 + > [AX25] ax25_ds_timer: use mod_timer instead of add_timer > > This patch changes current use of: init_timer(), add_timer() > and del_timer() to setup_timer() with mod_timer(), which > should be safer anyway. > > > R

Re: [PATCH][AX25] ax25_ds_timer: use mod_timer instead of add_timer

2008-02-10 Thread Jann Traschewski
t; Cc: Ralf Baechle; Jann Traschewski; David Miller > Betreff: [PATCH][AX25] ax25_ds_timer: use mod_timer instead > of add_timer > > On Wed, Feb 06, 2008 at 08:15:09AM +, Jarek Poplawski wrote: > > On Wed, Feb 06, 2008 at 07:45:29AM +, Jarek Poplawski wrote: > > .

Re: [PATCH][AX25] ax25_ds_timer: use mod_timer instead of add_timer

2008-02-10 Thread Bernard Pidoux F6BVP
Hi Jarek, Sorry, I should have been more explicit about the patches I applied. My CPU is an Intel Core 2 duo and I compiled 2.6.24 with SMP option. I applied 3 patches you have submitted for ax25 before I observed the possible locking. That is : mkiss patch diff --git a/drivers/net/hamradio

Re: [PATCH][AX25] ax25_ds_timer: use mod_timer instead of add_timer

2008-02-09 Thread Jarek Poplawski
On Sat, Feb 09, 2008 at 07:44:50PM +0100, Bernard Pidoux F6BVP wrote: > Hi, > > With AX25 patches applied I still get this possible circular locking > message. Hi Bernard, Could you confirm which exactly patches did you try? Is this vanilla 2.6.24 plus these two: ax25_timer and ax25_ds_timer or

[PATCH][AX25] ax25_ds_timer: use mod_timer instead of add_timer

2008-02-09 Thread Bernard Pidoux F6BVP
Hi, With AX25 patches applied I still get this possible circular locking message. Regards, Bernard P. === [ INFO: possible circular locking dependency detected ] 2.6.24 #3 --- swapper/

[PATCH][AX25] ax25_ds_timer: use mod_timer instead of add_timer

2008-02-06 Thread Jarek Poplawski
On Wed, Feb 06, 2008 at 08:15:09AM +, Jarek Poplawski wrote: > On Wed, Feb 06, 2008 at 07:45:29AM +, Jarek Poplawski wrote: > ... > > From: Jann Traschewski <[EMAIL PROTECTED]> > > Subject: SMP with AX.25 ... [AX25] ax25_ds_timer: use mod_timer instead of add_timer This patch changes cur