Re: [PATCH/RFC net-next 1/2] flow dissector: ND support

2017-03-13 Thread Jiri Pirko
Mon, Mar 13, 2017 at 02:50:08PM CET, simon.hor...@netronome.com wrote: >On Fri, Mar 10, 2017 at 03:27:32PM +0100, Jiri Pirko wrote: >> Fri, Mar 10, 2017 at 03:19:13PM CET, simon.hor...@netronome.com wrote: >> >On Tue, Feb 21, 2017 at 04:28:10PM +0100, Jiri Pirko wrote: >> >> Thu, Feb 02, 2017 at 11

Re: [PATCH/RFC net-next 1/2] flow dissector: ND support

2017-03-13 Thread Simon Horman
On Fri, Mar 10, 2017 at 03:27:32PM +0100, Jiri Pirko wrote: > Fri, Mar 10, 2017 at 03:19:13PM CET, simon.hor...@netronome.com wrote: > >On Tue, Feb 21, 2017 at 04:28:10PM +0100, Jiri Pirko wrote: > >> Thu, Feb 02, 2017 at 11:37:34AM CET, simon.hor...@netronome.com wrote: > >> >Allow dissection of N

Re: [PATCH/RFC net-next 1/2] flow dissector: ND support

2017-03-10 Thread Jiri Pirko
Fri, Mar 10, 2017 at 04:20:21PM CET, simon.hor...@netronome.com wrote: >On Fri, Mar 10, 2017 at 03:27:32PM +0100, Jiri Pirko wrote: >> Fri, Mar 10, 2017 at 03:19:13PM CET, simon.hor...@netronome.com wrote: >> >On Tue, Feb 21, 2017 at 04:28:10PM +0100, Jiri Pirko wrote: >> >> Thu, Feb 02, 2017 at 11

Re: [PATCH/RFC net-next 1/2] flow dissector: ND support

2017-03-10 Thread Simon Horman
On Fri, Mar 10, 2017 at 03:27:32PM +0100, Jiri Pirko wrote: > Fri, Mar 10, 2017 at 03:19:13PM CET, simon.hor...@netronome.com wrote: > >On Tue, Feb 21, 2017 at 04:28:10PM +0100, Jiri Pirko wrote: > >> Thu, Feb 02, 2017 at 11:37:34AM CET, simon.hor...@netronome.com wrote: > >> >Allow dissection of N

Re: [PATCH/RFC net-next 1/2] flow dissector: ND support

2017-03-10 Thread Jiri Pirko
Fri, Mar 10, 2017 at 03:19:13PM CET, simon.hor...@netronome.com wrote: >On Tue, Feb 21, 2017 at 04:28:10PM +0100, Jiri Pirko wrote: >> Thu, Feb 02, 2017 at 11:37:34AM CET, simon.hor...@netronome.com wrote: >> >Allow dissection of Neighbour Discovery target IP, and source and >> >destination link-la

Re: [PATCH/RFC net-next 1/2] flow dissector: ND support

2017-03-10 Thread Simon Horman
On Tue, Feb 21, 2017 at 04:28:10PM +0100, Jiri Pirko wrote: > Thu, Feb 02, 2017 at 11:37:34AM CET, simon.hor...@netronome.com wrote: > >Allow dissection of Neighbour Discovery target IP, and source and > >destination link-layer addresses for neighbour solicitation and > >advertisement messages. > >

Re: [PATCH/RFC net-next 1/2] flow dissector: ND support

2017-02-21 Thread Jiri Pirko
Thu, Feb 02, 2017 at 11:37:34AM CET, simon.hor...@netronome.com wrote: >Allow dissection of Neighbour Discovery target IP, and source and >destination link-layer addresses for neighbour solicitation and >advertisement messages. > >Signed-off-by: Simon Horman >--- [...] >@@ -633,6 +702,18 @@ bool

Re: [PATCH/RFC net-next 1/2] flow dissector: ND support

2017-02-21 Thread Jiri Pirko
Thu, Feb 02, 2017 at 07:36:31PM CET, t...@herbertland.com wrote: >On Thu, Feb 2, 2017 at 9:48 AM, Jiri Pirko wrote: >> Thu, Feb 02, 2017 at 06:24:40PM CET, t...@herbertland.com wrote: >>>On Thu, Feb 2, 2017 at 7:58 AM, Simon Horman >>>wrote: [Repost due to gmail account problem] O

Re: [oss-drivers] Re: [PATCH/RFC net-next 1/2] flow dissector: ND support

2017-02-09 Thread Simon Horman
On Wed, Feb 08, 2017 at 09:09:17PM +0100, Jiri Pirko wrote: > Wed, Feb 08, 2017 at 07:54:15PM CET, da...@davemloft.net wrote: > >From: Tom Herbert > >Date: Wed, 8 Feb 2017 10:33:46 -0800 > > > >> On Wed, Feb 8, 2017 at 1:28 AM, Simon Horman > >> wrote: > >>> I think the above paragraph gets back

Re: [oss-drivers] Re: [PATCH/RFC net-next 1/2] flow dissector: ND support

2017-02-08 Thread Jiri Pirko
Wed, Feb 08, 2017 at 08:10:06PM CET, t...@herbertland.com wrote: >On Wed, Feb 8, 2017 at 10:54 AM, David Miller wrote: >> From: Tom Herbert >> Date: Wed, 8 Feb 2017 10:33:46 -0800 >> >>> On Wed, Feb 8, 2017 at 1:28 AM, Simon Horman >>> wrote: I think the above paragraph gets back to Tom's

Re: [oss-drivers] Re: [PATCH/RFC net-next 1/2] flow dissector: ND support

2017-02-08 Thread Tom Herbert
On Wed, Feb 8, 2017 at 12:12 PM, Jiri Pirko wrote: > Wed, Feb 08, 2017 at 08:10:06PM CET, t...@herbertland.com wrote: >>On Wed, Feb 8, 2017 at 10:54 AM, David Miller wrote: >>> From: Tom Herbert >>> Date: Wed, 8 Feb 2017 10:33:46 -0800 >>> On Wed, Feb 8, 2017 at 1:28 AM, Simon Horman

Re: [oss-drivers] Re: [PATCH/RFC net-next 1/2] flow dissector: ND support

2017-02-08 Thread Jiri Pirko
Wed, Feb 08, 2017 at 07:54:15PM CET, da...@davemloft.net wrote: >From: Tom Herbert >Date: Wed, 8 Feb 2017 10:33:46 -0800 > >> On Wed, Feb 8, 2017 at 1:28 AM, Simon Horman >> wrote: >>> I think the above paragraph gets back to Tom's original question regarding >>> making things more complex just

Re: [oss-drivers] Re: [PATCH/RFC net-next 1/2] flow dissector: ND support

2017-02-08 Thread Tom Herbert
On Wed, Feb 8, 2017 at 10:54 AM, David Miller wrote: > From: Tom Herbert > Date: Wed, 8 Feb 2017 10:33:46 -0800 > >> On Wed, Feb 8, 2017 at 1:28 AM, Simon Horman >> wrote: >>> I think the above paragraph gets back to Tom's original question regarding >>> making things more complex just for OvS

Re: [oss-drivers] Re: [PATCH/RFC net-next 1/2] flow dissector: ND support

2017-02-08 Thread David Miller
From: Tom Herbert Date: Wed, 8 Feb 2017 10:33:46 -0800 > On Wed, Feb 8, 2017 at 1:28 AM, Simon Horman > wrote: >> I think the above paragraph gets back to Tom's original question regarding >> making things more complex just for OvS (use-cases). Possibly ND is an edge >> case even for OvS and on

Re: [oss-drivers] Re: [PATCH/RFC net-next 1/2] flow dissector: ND support

2017-02-08 Thread Tom Herbert
On Wed, Feb 8, 2017 at 1:28 AM, Simon Horman wrote: > On Tue, Feb 07, 2017 at 12:38:31PM -0500, David Miller wrote: >> From: Tom Herbert >> Date: Tue, 7 Feb 2017 09:36:20 -0800 >> >> > Okay, but can you give us an idea of how many more of these protocols >> > are going to be added to flow_dissect

Re: [PATCH/RFC net-next 1/2] flow dissector: ND support

2017-02-08 Thread Simon Horman
Responding to myself as my previous post doesn't seem to have hit netdev for some reason. On Wed, Feb 08, 2017 at 10:28:24AM +0100, Simon Horman wrote: > On Tue, Feb 07, 2017 at 12:38:31PM -0500, David Miller wrote: > > From: Tom Herbert > > Date: Tue, 7 Feb 2017 09:36:20 -0800 > > > > > Okay, b

Re: [oss-drivers] Re: [PATCH/RFC net-next 1/2] flow dissector: ND support

2017-02-08 Thread Simon Horman
On Tue, Feb 07, 2017 at 12:38:31PM -0500, David Miller wrote: > From: Tom Herbert > Date: Tue, 7 Feb 2017 09:36:20 -0800 > > > Okay, but can you give us an idea of how many more of these protocols > > are going to be added to flow_dissector. TBH I'm not very enthused > > about making more flow_di

Re: [oss-drivers] Re: [PATCH/RFC net-next 1/2] flow dissector: ND support

2017-02-07 Thread David Miller
From: Tom Herbert Date: Tue, 7 Feb 2017 09:36:20 -0800 > Okay, but can you give us an idea of how many more of these protocols > are going to be added to flow_dissector. TBH I'm not very enthused > about making more flow_dissector more complex for the benefit of OVS. Especially since the kernel

Re: [oss-drivers] Re: [PATCH/RFC net-next 1/2] flow dissector: ND support

2017-02-07 Thread Tom Herbert
On Mon, Feb 6, 2017 at 1:12 AM, Simon Horman wrote: > On Thu, Feb 02, 2017 at 10:36:31AM -0800, Tom Herbert wrote: >> On Thu, Feb 2, 2017 at 9:48 AM, Jiri Pirko wrote: >> > Thu, Feb 02, 2017 at 06:24:40PM CET, t...@herbertland.com wrote: >> >>On Thu, Feb 2, 2017 at 7:58 AM, Simon Horman >> >>wr

Re: [oss-drivers] Re: [PATCH/RFC net-next 1/2] flow dissector: ND support

2017-02-06 Thread Simon Horman
On Thu, Feb 02, 2017 at 10:36:31AM -0800, Tom Herbert wrote: > On Thu, Feb 2, 2017 at 9:48 AM, Jiri Pirko wrote: > > Thu, Feb 02, 2017 at 06:24:40PM CET, t...@herbertland.com wrote: > >>On Thu, Feb 2, 2017 at 7:58 AM, Simon Horman > >>wrote: > >>> [Repost due to gmail account problem] > >>> > >>

Re: [PATCH/RFC net-next 1/2] flow dissector: ND support

2017-02-02 Thread Tom Herbert
On Thu, Feb 2, 2017 at 10:56 AM, Eric Dumazet wrote: > On Thu, 2017-02-02 at 10:36 -0800, Tom Herbert wrote: > >> It's going to be a problem with a whole host of application level >> protocols especially those run over UDP. QUIC is a great example. The >> actual protocol will probably only ever ru

Re: [PATCH/RFC net-next 1/2] flow dissector: ND support

2017-02-02 Thread Eric Dumazet
On Thu, 2017-02-02 at 10:36 -0800, Tom Herbert wrote: > It's going to be a problem with a whole host of application level > protocols especially those run over UDP. QUIC is a great example. The > actual protocol will probably only ever run in userspace, but it is > inevitable that we want to provi

Re: [PATCH/RFC net-next 1/2] flow dissector: ND support

2017-02-02 Thread Tom Herbert
On Thu, Feb 2, 2017 at 9:48 AM, Jiri Pirko wrote: > Thu, Feb 02, 2017 at 06:24:40PM CET, t...@herbertland.com wrote: >>On Thu, Feb 2, 2017 at 7:58 AM, Simon Horman >>wrote: >>> [Repost due to gmail account problem] >>> >>> On Thu, Feb 02, 2017 at 04:31:33AM -0800, Eric Dumazet wrote: On Thu

Re: [PATCH/RFC net-next 1/2] flow dissector: ND support

2017-02-02 Thread Jiri Pirko
Thu, Feb 02, 2017 at 06:24:40PM CET, t...@herbertland.com wrote: >On Thu, Feb 2, 2017 at 7:58 AM, Simon Horman >wrote: >> [Repost due to gmail account problem] >> >> On Thu, Feb 02, 2017 at 04:31:33AM -0800, Eric Dumazet wrote: >>> On Thu, 2017-02-02 at 11:37 +0100, Simon Horman wrote: >>> > Allo

Re: [PATCH/RFC net-next 1/2] flow dissector: ND support

2017-02-02 Thread Tom Herbert
On Thu, Feb 2, 2017 at 7:58 AM, Simon Horman wrote: > [Repost due to gmail account problem] > > On Thu, Feb 02, 2017 at 04:31:33AM -0800, Eric Dumazet wrote: >> On Thu, 2017-02-02 at 11:37 +0100, Simon Horman wrote: >> > Allow dissection of Neighbour Discovery target IP, and source and >> > destin

Re: [PATCH/RFC net-next 1/2] flow dissector: ND support

2017-02-02 Thread Simon Horman
[Repost due to gmail account problem] On Thu, Feb 02, 2017 at 04:31:33AM -0800, Eric Dumazet wrote: > On Thu, 2017-02-02 at 11:37 +0100, Simon Horman wrote: > > Allow dissection of Neighbour Discovery target IP, and source and > > destination link-layer addresses for neighbour solicitation and > >

Re: [PATCH/RFC net-next 1/2] flow dissector: ND support

2017-02-02 Thread Eric Dumazet
On Thu, 2017-02-02 at 11:37 +0100, Simon Horman wrote: > Allow dissection of Neighbour Discovery target IP, and source and > destination link-layer addresses for neighbour solicitation and > advertisement messages. > > Signed-off-by: Simon Horman > --- Hi Simon Why is this needed ? Any code ad

[PATCH/RFC net-next 1/2] flow dissector: ND support

2017-02-02 Thread Simon Horman
Allow dissection of Neighbour Discovery target IP, and source and destination link-layer addresses for neighbour solicitation and advertisement messages. Signed-off-by: Simon Horman --- include/net/flow_dissector.h | 14 net/core/flow_dissector.c| 83