Re: [PATCH/RFC net] ravb: do not use zero-length alighment DMA request

2017-01-12 Thread Sergei Shtylyov
On 01/12/2017 07:04 PM, David Miller wrote: What I now see is that a few lines further up there is: if (skb_put_padto(skb, ETH_ZLEN)) goto drop; where ETH_ZLEN is 60. So I don't think we need to worry about skb->len being less than 60 and this patch can be sim

Re: [PATCH/RFC net] ravb: do not use zero-length alighment DMA request

2017-01-12 Thread David Miller
From: Simon Horman Date: Thu, 12 Jan 2017 16:46:47 +0100 > What I now see is that a few lines further up there is: > >if (skb_put_padto(skb, ETH_ZLEN)) > goto drop; > > where ETH_ZLEN is 60. > > So I don't think we need to worry about skb->len being less than 60 and

Re: [PATCH/RFC net] ravb: do not use zero-length alighment DMA request

2017-01-12 Thread Sergei Shtylyov
On 01/12/2017 04:53 PM, Simon Horman wrote: From: Masaru Nagai Due to alignment requirements of the hardware transmissions are split into two DMA requests, Rather DMA descriptors. a small padding request of 0 - 4 bytes in length 0..3 currently. followed by the a request for rest

Re: [PATCH/RFC net] ravb: do not use zero-length alighment DMA request

2017-01-12 Thread Simon Horman
On Thu, Jan 12, 2017 at 10:21:02AM -0500, David Miller wrote: > From: Simon Horman > Date: Thu, 12 Jan 2017 14:53:37 +0100 > > > diff --git a/drivers/net/ethernet/renesas/ravb_main.c > > b/drivers/net/ethernet/renesas/ravb_main.c > > index 92d7692c840d..3b4d2504285e 100644 > > --- a/drivers/net/

Re: [PATCH/RFC net] ravb: do not use zero-length alighment DMA request

2017-01-12 Thread David Miller
From: Simon Horman Date: Thu, 12 Jan 2017 14:53:37 +0100 > diff --git a/drivers/net/ethernet/renesas/ravb_main.c > b/drivers/net/ethernet/renesas/ravb_main.c > index 92d7692c840d..3b4d2504285e 100644 > --- a/drivers/net/ethernet/renesas/ravb_main.c > +++ b/drivers/net/ethernet/renesas/ravb_main.

[PATCH/RFC net] ravb: do not use zero-length alighment DMA request

2017-01-12 Thread Simon Horman
From: Masaru Nagai Due to alignment requirements of the hardware transmissions are split into two DMA requests, a small padding request of 0 - 4 bytes in length followed by the a request for rest of the packet. In the case of IP packets the first request will never be zero due to the way that th