Re: [PATCH/RFC bpf-next 02/16] bpf: refactor propagate_live implementation

2019-03-27 Thread Jiong Wang
> On 27 Mar 2019, at 16:35, Alexei Starovoitov > wrote: > > On Tue, Mar 26, 2019 at 06:05:25PM +, Jiong Wang wrote: >> Some code inside current implementation of "propagate_liveness" is a little >> bit verbose. >> >> This patch refactor them so the code looks more simple and more clear. >

Re: [PATCH/RFC bpf-next 02/16] bpf: refactor propagate_live implementation

2019-03-27 Thread Alexei Starovoitov
On Tue, Mar 26, 2019 at 06:05:25PM +, Jiong Wang wrote: > Some code inside current implementation of "propagate_liveness" is a little > bit verbose. > > This patch refactor them so the code looks more simple and more clear. > > The redundant usage of "vparent->frame[vstate->curframe]" is remo

Re: [PATCH/RFC bpf-next 02/16] bpf: refactor propagate_live implementation

2019-03-26 Thread Jiong Wang
On 26/03/2019 18:26, Jann Horn wrote: On Tue, Mar 26, 2019 at 7:07 PM Jiong Wang wrote: Some code inside current implementation of "propagate_liveness" is a little bit verbose. This patch refactor them so the code looks more simple and more clear. The redundant usage of "vparent->frame[vstate

Re: [PATCH/RFC bpf-next 02/16] bpf: refactor propagate_live implementation

2019-03-26 Thread Jann Horn
On Tue, Mar 26, 2019 at 7:07 PM Jiong Wang wrote: > Some code inside current implementation of "propagate_liveness" is a little > bit verbose. > > This patch refactor them so the code looks more simple and more clear. > > The redundant usage of "vparent->frame[vstate->curframe]" is removed as we >

[PATCH/RFC bpf-next 02/16] bpf: refactor propagate_live implementation

2019-03-26 Thread Jiong Wang
Some code inside current implementation of "propagate_liveness" is a little bit verbose. This patch refactor them so the code looks more simple and more clear. The redundant usage of "vparent->frame[vstate->curframe]" is removed as we are here. It is safe to do this because "state_equal" has guar