Re: [PATCH/RFC] [v3] TCP: use non-delayed ACK for congestion control RTT

2007-12-30 Thread Gavin McCullagh
On Sun, 30 Dec 2007, Ilpo Järvinen wrote: > I guess the non-minimum TSO delays are only significant in case there was > something unexpectional happening and in such case we definately want to > have some measurements taken. Broadly speaking, delay-based schemes need as much information about t

Re: [PATCH/RFC] [v3] TCP: use non-delayed ACK for congestion control RTT

2007-12-30 Thread Gavin McCullagh
Hi, On Sat, 29 Dec 2007, David Miller wrote: > Never mind about making the relative patch, I didn't want to have > to wait for you to send me that and have it block my merge of > fixes with Linus this evening. Ah, sorry for the inconvenience. I didn't realise you had merged it yet. > The follo

Re: [PATCH/RFC] [v3] TCP: use non-delayed ACK for congestion control RTT

2007-12-30 Thread Ilpo Järvinen
On Sun, 30 Dec 2007, Gavin McCullagh wrote: > Hi, > > On Fri, 21 Dec 2007, Ilpo Järvinen wrote: > > > > I need to re-read properly, but I think the same problem affects the > > > microsecond values where TCP_CONG_RTT_STAMP is set (used by vegas, veno, > > > yeah, illinois). I might follow up wi

Re: [PATCH/RFC] [v3] TCP: use non-delayed ACK for congestion control RTT

2007-12-29 Thread David Miller
Never mind about making the relative patch, I didn't want to have to wait for you to send me that and have it block my merge of fixes with Linus this evening. The following is what I applied on top of your other patch: diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c index 6fb7989..cbba2

Re: [PATCH/RFC] [v3] TCP: use non-delayed ACK for congestion control RTT

2007-12-29 Thread David Miller
From: Gavin McCullagh <[EMAIL PROTECTED]> Date: Sun, 30 Dec 2007 01:15:00 + > A combined patch will follow this mail. Please send a relative patch, I've already applied your original patch to: kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6.git and will be sending that to Linus s

Re: [PATCH/RFC] [v3] TCP: use non-delayed ACK for congestion control RTT

2007-12-29 Thread Gavin McCullagh
When a delayed ACK representing two packets arrives, there are two RTT samples available, one for each packet. The first (in order of seq number) will be artificially long due to the delay waiting for the second packet, the second will trigger the ACK and so will not itself be delayed. According

Re: [PATCH/RFC] [v3] TCP: use non-delayed ACK for congestion control RTT

2007-12-29 Thread Gavin McCullagh
Hi, On Fri, 21 Dec 2007, Ilpo Järvinen wrote: > > I need to re-read properly, but I think the same problem affects the > > microsecond values where TCP_CONG_RTT_STAMP is set (used by vegas, veno, > > yeah, illinois). I might follow up with another patch which changes the > > behaviour where TCP_