Re: [PATCH, net-next] perf, bpf: fix conditional call to bpf_overflow_handler

2016-09-08 Thread Ingo Molnar
* Daniel Borkmann wrote: > On 09/08/2016 09:01 AM, Ingo Molnar wrote: > >* Peter Zijlstra wrote: > >>On Thu, Sep 08, 2016 at 08:30:52AM +0200, Ingo Molnar wrote: > Thanks for the fix. Just saw build bot complaining last night and > by the morning your fix is already here. Thanks! > >>>

Re: [PATCH, net-next] perf, bpf: fix conditional call to bpf_overflow_handler

2016-09-08 Thread Daniel Borkmann
On 09/08/2016 09:01 AM, Ingo Molnar wrote: * Peter Zijlstra wrote: On Thu, Sep 08, 2016 at 08:30:52AM +0200, Ingo Molnar wrote: Thanks for the fix. Just saw build bot complaining last night and by the morning your fix is already here. Thanks! Guys, this is the first time I saw this patch (an

Re: [PATCH, net-next] perf, bpf: fix conditional call to bpf_overflow_handler

2016-09-08 Thread Ingo Molnar
* Peter Zijlstra wrote: > On Thu, Sep 08, 2016 at 08:30:52AM +0200, Ingo Molnar wrote: > > > Thanks for the fix. Just saw build bot complaining last night and > > > by the morning your fix is already here. Thanks! > > > > Guys, this is the first time I saw this patch (and presumably there's som

Re: [PATCH, net-next] perf, bpf: fix conditional call to bpf_overflow_handler

2016-09-07 Thread Peter Zijlstra
On Thu, Sep 08, 2016 at 08:30:52AM +0200, Ingo Molnar wrote: > > Thanks for the fix. Just saw build bot complaining last night and > > by the morning your fix is already here. Thanks! > > Guys, this is the first time I saw this patch (and presumably there's some > other > patch as well?) - could

Re: [PATCH, net-next] perf, bpf: fix conditional call to bpf_overflow_handler

2016-09-07 Thread Ingo Molnar
* Alexei Starovoitov wrote: > On Tue, Sep 06, 2016 at 03:10:22PM +0200, Arnd Bergmann wrote: > > The newly added bpf_overflow_handler function is only built of both > > CONFIG_EVENT_TRACING and CONFIG_BPF_SYSCALL are enabled, but the caller > > only checks the latter: > > > > kernel/events/core

Re: [PATCH, net-next] perf, bpf: fix conditional call to bpf_overflow_handler

2016-09-06 Thread Alexei Starovoitov
On Tue, Sep 06, 2016 at 03:10:22PM +0200, Arnd Bergmann wrote: > The newly added bpf_overflow_handler function is only built of both > CONFIG_EVENT_TRACING and CONFIG_BPF_SYSCALL are enabled, but the caller > only checks the latter: > > kernel/events/core.c: In function 'perf_event_alloc': > kerne

[PATCH, net-next] perf, bpf: fix conditional call to bpf_overflow_handler

2016-09-06 Thread Arnd Bergmann
The newly added bpf_overflow_handler function is only built of both CONFIG_EVENT_TRACING and CONFIG_BPF_SYSCALL are enabled, but the caller only checks the latter: kernel/events/core.c: In function 'perf_event_alloc': kernel/events/core.c:9106:27: error: 'bpf_overflow_handler' undeclared (first u