Re: [NET]: Take RTNL when unregistering notifier

2006-03-25 Thread Herbert Xu
On Sat, Mar 25, 2006 at 01:24:55AM -0800, David S. Miller wrote: > > Looks great, applied. > > Did you actually encounter some bug due to this or it is purely > from code audit? It's code inspection arising out of the parameterised crypto stuff that I'm currently working on. Cheers, -- Visit Op

Re: [NET]: Take RTNL when unregistering notifier

2006-03-25 Thread David S. Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Sat, 25 Mar 2006 16:00:51 +1100 > The netdev notifier call chain is currently unregistered without taking > any locks outside the notifier system. Because the notifier system itself > does not synchronise unregistration with respect to the calling of the

[NET]: Take RTNL when unregistering notifier

2006-03-24 Thread Herbert Xu
Hi Dave: The netdev notifier call chain is currently unregistered without taking any locks outside the notifier system. Because the notifier system itself does not synchronise unregistration with respect to the calling of the chain, we as its user need to do our own locking. We are supposed to t