Re: [NET]: Get rid of alloc_skb code duplication

2007-04-17 Thread David Miller
From: Herbert Xu <[EMAIL PROTECTED]> Date: Wed, 18 Apr 2007 00:17:43 +1000 > On Tue, Apr 17, 2007 at 02:03:47PM +0100, Christoph Hellwig wrote: > > > > It was put in for Xen, but if you as the resident beat the crap out > > of Xen networking guru don't know about it we should probably just > > kil

Re: [NET]: Get rid of alloc_skb code duplication

2007-04-17 Thread Herbert Xu
On Tue, Apr 17, 2007 at 02:03:47PM +0100, Christoph Hellwig wrote: > > It was put in for Xen, but if you as the resident beat the crap out > of Xen networking guru don't know about it we should probably just > kill it. Especially as we usually kill dead code pretty fast. Heh, I wasn't touching Xe

Re: [NET]: Get rid of alloc_skb code duplication

2007-04-17 Thread Christoph Hellwig
On Tue, Apr 17, 2007 at 09:57:46PM +1000, Herbert Xu wrote: > Hi Dave: > > [NET]: Get rid of alloc_skb code duplication > > The skb initialisation code is shared between alloc_skb and > alloc_skb_from_cache. Now I don't know what actually uses > the latter so perhaps

[NET]: Get rid of alloc_skb code duplication

2007-04-17 Thread Herbert Xu
Hi Dave: [NET]: Get rid of alloc_skb code duplication The skb initialisation code is shared between alloc_skb and alloc_skb_from_cache. Now I don't know what actually uses the latter so perhaps we could simply get rid of it. However, if we're to keep it, then let's move the com