From: "Michael Chan" <[EMAIL PROTECTED]>
Date: Sun, 23 Dec 2007 16:20:35 -0800
> Here's the revised patch:
>
> [ETH]: Combine format_addr() with print_mac().
>
> print_mac() used many most net drivers and format_addr() used by
> net-sysfs.c are v
nless to change the prototype.
> size_t seems more sensible.
>
I'll change the internal function to use size_t, but the exported
function for sysfs use will be ssize_t since sysfs uses ssize_t.
Here's the revised patch:
[ETH]: Combine format_addr() with print_mac().
print_mac() use
On Fri, 2007-12-21 at 19:58 -0800, Michael Chan wrote:
> The dev_addr is declared as unsigned char* in struct net_device. To be
> consistent, can we change print_mac() and MAC_BUF to use unsigned char*?
> They are really the same.
That's fine by me. I like consistency.
I don't remember why it wa
On Fri, 2007-12-21 at 14:36 -0800, Joe Perches wrote:
> On Fri, 2007-12-21 at 14:05 -0800, Michael Chan wrote:
> > diff --git a/net/ethernet/eth.c b/net/ethernet/eth.c
> > index 6b2e454..f760d41 100644
> > --- a/net/ethernet/eth.c
> > +++ b/net/ethernet/eth.c
> > @@ -359,10 +359,33 @@ struct net_de
On Fri, 2007-12-21 at 14:05 -0800, Michael Chan wrote:
> [ETH]: Combine format_addr() with print_mac().
> print_mac() used by most net drivers and format_addr() used by
> net-sysfs.c are very similar and they can be integrated.
> format_addr() is also identically redefined in the q
[ETH]: Combine format_addr() with print_mac().
print_mac() used by most net drivers and format_addr() used by
net-sysfs.c are very similar and they can be integrated.
format_addr() is also identically redefined in the qla4xxx iscsi
driver.
Export a new function format_mac_addr() to be used by
