From: Steven Whitehouse <[EMAIL PROTECTED]>
Date: Mon, 06 Nov 2006 10:31:02 +
> Hi,
>
> Here is a patch which fixes some endianess problems. Patrick: since you
> have both big & little endian machines at your disposal, can you test to
> ensure this is ok? Thanks,
Applied, thanks Steven and A
Hi,
On Mon, 2006-11-06 at 10:34 +, Al Viro wrote:
> On Mon, Nov 06, 2006 at 10:32:43AM +, Al Viro wrote:
> > On Mon, Nov 06, 2006 at 10:31:02AM +, Steven Whitehouse wrote:
> > > + opt->opt_optl = dn_htons((__u16)*ptr++);
> >
> > Lose that cast; it's only confusing the things...
> >
Hi,
On Mon, 2006-11-06 at 10:32 +, Al Viro wrote:
> On Mon, Nov 06, 2006 at 10:31:02AM +, Steven Whitehouse wrote:
> > + opt->opt_optl = dn_htons((__u16)*ptr++);
>
> Lose that cast; it's only confusing the things...
>
> > + memcpy(opt->opt_data, ptr, dn_ntohs(opt->opt_optl));
> > +
On Mon, Nov 06, 2006 at 10:31:02AM +, Steven Whitehouse wrote:
> + opt->opt_optl = dn_htons((__u16)*ptr++);
Lose that cast; it's only confusing the things...
> + memcpy(opt->opt_data, ptr, dn_ntohs(opt->opt_optl));
> + skb_pull(skb, dn_ntohs(opt->opt_optl) + 1);
... and I'd act
On Mon, Nov 06, 2006 at 10:32:43AM +, Al Viro wrote:
> On Mon, Nov 06, 2006 at 10:31:02AM +, Steven Whitehouse wrote:
> > + opt->opt_optl = dn_htons((__u16)*ptr++);
>
> Lose that cast; it's only confusing the things...
>
> > + memcpy(opt->opt_data, ptr, dn_ntohs(opt->opt_optl));
> >
Hi,
Here is a patch which fixes some endianess problems. Patrick: since you
have both big & little endian machines at your disposal, can you test to
ensure this is ok? Thanks,
Steve.
>From ed3de950e89f8b02302308a2bedd59123ff3b88e Mon Sep 17 00:00:00 2001
From: Steven Whitehouse <[EMAIL PROTECTED
