Re: [Bonding-devel] [PATCH 3/3] bonding: Improve IGMP join processing

2007-03-09 Thread Andy Gospodarek
On Tue, Mar 06, 2007 at 07:21:30PM -0800, David Stevens wrote: > > >Marking the master down would, I believe, issue notifiers that > > > the device has gone down. Various things, network manager sort of > > > applications in particular, listen to those, so I'm not sure it's a > good > > > id

Re: [Bonding-devel] [PATCH 3/3] bonding: Improve IGMP join processing

2007-03-06 Thread David Stevens
> >Marking the master down would, I believe, issue notifiers that > > the device has gone down. Various things, network manager sort of > > applications in particular, listen to those, so I'm not sure it's a good > > idea. I think there are other side effects as well, I'm thinking it > > wo

Re: [Bonding-devel] [PATCH 3/3] bonding: Improve IGMP join processing

2007-03-06 Thread Andy Gospodarek
On Tue, Mar 06, 2007 at 03:15:41PM -0800, Jay Vosburgh wrote: > > David Stevens <[EMAIL PROTECTED]> wrote: > > >It looks to me like "rejoin" is essentially ip_mc_up(), and it'd be better > >to call that than add a nearly identical function. > > Won't ip_mc_up() acquire an additional refere

Re: [Bonding-devel] [PATCH 3/3] bonding: Improve IGMP join processing

2007-03-06 Thread David Stevens
[EMAIL PROTECTED] wrote on 03/06/2007 03:15:41 PM: > > David Stevens <[EMAIL PROTECTED]> wrote: > > >It looks to me like "rejoin" is essentially ip_mc_up(), and it'd be better > >to call that than add a nearly identical function. > >Won't ip_mc_up() acquire an additional reference (via > i

Re: [Bonding-devel] [PATCH 3/3] bonding: Improve IGMP join processing

2007-03-06 Thread Jay Vosburgh
David Stevens <[EMAIL PROTECTED]> wrote: >It looks to me like "rejoin" is essentially ip_mc_up(), and it'd be better >to call that than add a nearly identical function. Won't ip_mc_up() acquire an additional reference (via ip_mc_inc_group) to the IGMP_ALL_HOSTS im->users that would never