Re: [BUG] bcmgenet tx path

2016-03-19 Thread Florian Fainelli
Hi Eric, On 16/03/16 07:18, Eric Dumazet wrote: > Hi Florian > > I was looking at drivers/net/ethernet/broadcom/genet/bcmgenet.c > and found TX completion (__bcmgenet_tx_reclaim()) was freeing skb before > frags were actually dma unmapped. > > > Are you sure this is OK ? bnx2 and bnx2x actually

[BUG] bcmgenet tx path

2016-03-19 Thread Eric Dumazet
Hi Florian I was looking at drivers/net/ethernet/broadcom/genet/bcmgenet.c and found TX completion (__bcmgenet_tx_reclaim()) was freeing skb before frags were actually dma unmapped. Are you sure this is OK ? bnx2 and bnx2x actually do the reverse (unmap all frags before freeing skb) A second pr