Re: [BISECTED] v4.5-rc1 phylib regression

2016-01-26 Thread Andrew Lunn
On Tue, Jan 26, 2016 at 03:54:13PM -0800, Florian Fainelli wrote: > On 26/01/16 14:09, Andrew Lunn wrote: > >>> Nope, not an option. Only a small number of DTB actually use c22 or > >>> c45. The majority of devices have no compatible at all. Why should > >>> they, the binding documentation says it

Re: [BISECTED] v4.5-rc1 phylib regression

2016-01-26 Thread Florian Fainelli
On 26/01/16 14:09, Andrew Lunn wrote: >>> Nope, not an option. Only a small number of DTB actually use c22 or >>> c45. The majority of devices have no compatible at all. Why should >>> they, the binding documentation says it is optional! >> >> So one thing that can be done is to just have a whiteli

Re: [BISECTED] v4.5-rc1 phylib regression

2016-01-26 Thread Andrew Lunn
> > Nope, not an option. Only a small number of DTB actually use c22 or > > c45. The majority of devices have no compatible at all. Why should > > they, the binding documentation says it is optional! > > So one thing that can be done is to just have a whitelist in the > driver that we add the know

Re: [BISECTED] v4.5-rc1 phylib regression

2016-01-26 Thread Olof Johansson
On Tue, Jan 26, 2016 at 1:36 PM, Andrew Lunn wrote: > On Tue, Jan 26, 2016 at 12:46:31PM -0800, Florian Fainelli wrote: >> On 26/01/16 10:14, Olof Johansson wrote: >> > +devicet...@vger.kernel.org instead. >> > >> > On Tue, Jan 26, 2016 at 10:08 AM, Olof Johansson wrote: >> >> On Tue, Jan 26, 201

Re: [BISECTED] v4.5-rc1 phylib regression

2016-01-26 Thread Andrew Lunn
On Tue, Jan 26, 2016 at 12:46:31PM -0800, Florian Fainelli wrote: > On 26/01/16 10:14, Olof Johansson wrote: > > +devicet...@vger.kernel.org instead. > > > > On Tue, Jan 26, 2016 at 10:08 AM, Olof Johansson wrote: > >> On Tue, Jan 26, 2016 at 9:53 AM, Andrew Lunn wrote: > I hate to bikeshed

Re: [BISECTED] v4.5-rc1 phylib regression

2016-01-26 Thread Florian Fainelli
On 26/01/16 10:14, Olof Johansson wrote: > +devicet...@vger.kernel.org instead. > > On Tue, Jan 26, 2016 at 10:08 AM, Olof Johansson wrote: >> On Tue, Jan 26, 2016 at 9:53 AM, Andrew Lunn wrote: I hate to bikeshed, but I'm not sure if "generic-mdio" is too... generic? Will someone writ

Re: [BISECTED] v4.5-rc1 phylib regression

2016-01-26 Thread Olof Johansson
+devicet...@vger.kernel.org instead. On Tue, Jan 26, 2016 at 10:08 AM, Olof Johansson wrote: > On Tue, Jan 26, 2016 at 9:53 AM, Andrew Lunn wrote: >>> I hate to bikeshed, but I'm not sure if "generic-mdio" is too... >>> generic? Will someone writing a DT be thinking "well, this is a >>> generic

Re: [BISECTED] v4.5-rc1 phylib regression

2016-01-26 Thread Olof Johansson
On Tue, Jan 26, 2016 at 9:53 AM, Andrew Lunn wrote: >> I hate to bikeshed, but I'm not sure if "generic-mdio" is too... >> generic? Will someone writing a DT be thinking "well, this is a >> generic mdio PHY, I should set it"? "mdio-device"? >> "generic-nonphy-mdio"? Neither of those seem much bet

Re: [BISECTED] v4.5-rc1 phylib regression

2016-01-26 Thread Andrew Lunn
> I hate to bikeshed, but I'm not sure if "generic-mdio" is too... > generic? Will someone writing a DT be thinking "well, this is a > generic mdio PHY, I should set it"? "mdio-device"? > "generic-nonphy-mdio"? Neither of those seem much better. How about 'not-a-phy'? Andrew

Re: [BISECTED] v4.5-rc1 phylib regression

2016-01-26 Thread Olof Johansson
On Tue, Jan 26, 2016 at 5:34 AM, Andrew Lunn wrote: > On Tue, Jan 26, 2016 at 02:14:35PM +0200, Aaro Koskinen wrote: >> Hi, >> >> On Tue, Jan 26, 2016 at 05:46:24AM +0100, Andrew Lunn wrote: >> > On Mon, Jan 25, 2016 at 05:45:21PM +0200, Aaro Koskinen wrote: >> > > I get the below crash on OCTEON

Re: [BISECTED] v4.5-rc1 phylib regression

2016-01-26 Thread Andrew Lunn
On Tue, Jan 26, 2016 at 02:14:35PM +0200, Aaro Koskinen wrote: > Hi, > > On Tue, Jan 26, 2016 at 05:46:24AM +0100, Andrew Lunn wrote: > > On Mon, Jan 25, 2016 at 05:45:21PM +0200, Aaro Koskinen wrote: > > > I get the below crash on OCTEON (with octeon_mgmt interface, genphy) > > > always during sy

Re: [BISECTED] v4.5-rc1 phylib regression

2016-01-26 Thread Aaro Koskinen
Hi, On Tue, Jan 26, 2016 at 05:46:24AM +0100, Andrew Lunn wrote: > On Mon, Jan 25, 2016 at 05:45:21PM +0200, Aaro Koskinen wrote: > > I get the below crash on OCTEON (with octeon_mgmt interface, genphy) > > always during systemd boot. > > I think i know what is going on now. > > What does your p

Re: [BISECTED] v4.5-rc1 phylib regression

2016-01-25 Thread Andrew Lunn
On Mon, Jan 25, 2016 at 05:45:21PM +0200, Aaro Koskinen wrote: > Hi, > > I get the below crash on OCTEON (with octeon_mgmt interface, genphy) > always during systemd boot. Hi Aaro I think i know what is going on now. What does your phy look like in DT? Thanks Andrew

Re: [BISECTED] v4.5-rc1 phylib regression

2016-01-25 Thread Andrew Lunn
On Mon, Jan 25, 2016 at 05:45:21PM +0200, Aaro Koskinen wrote: > Hi, > > I get the below crash on OCTEON (with octeon_mgmt interface, genphy) > always during systemd boot. > > Bisected to: > > commit a9049e0c513c4521dbfaa302af8ed08b3366b41f > Author: Andrew Lunn > Date: Wed Jan 6 20:11:26 201

Re: [BISECTED] v4.5-rc1 phylib regression

2016-01-25 Thread Andrew Lunn
On Mon, Jan 25, 2016 at 05:45:21PM +0200, Aaro Koskinen wrote: > Hi, > > I get the below crash on OCTEON (with octeon_mgmt interface, genphy) > always during systemd boot. Hi Aaro Olof reported a similar issue with a Marvell Ethernet driver/MDIO driver. Olof thinking was the mutex was used befor

[BISECTED] v4.5-rc1 phylib regression

2016-01-25 Thread Aaro Koskinen
Hi, I get the below crash on OCTEON (with octeon_mgmt interface, genphy) always during systemd boot. Bisected to: commit a9049e0c513c4521dbfaa302af8ed08b3366b41f Author: Andrew Lunn Date: Wed Jan 6 20:11:26 2016 +0100 mdio: Add support for mdio drivers. [ 250.179887] CPU 2 Unable to ha