Re: [2.6 patch] kill net/rxrpc/rxrpc_syms.c

2007-02-20 Thread Adrian Bunk
On Tue, Feb 20, 2007 at 10:59:46AM +, David Howells wrote: > Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > } /* end rxrpc_create_call() */ > > +EXPORT_SYMBOL(rxrpc_create_call); > > A blank line between the end of the function and the EXPORT_SYMBOL please. Please discuss this with Andrew [1]

Re: [2.6 patch] kill net/rxrpc/rxrpc_syms.c

2007-02-20 Thread David Howells
Adrian Bunk <[EMAIL PROTECTED]> wrote: > } /* end rxrpc_create_call() */ > +EXPORT_SYMBOL(rxrpc_create_call); A blank line between the end of the function and the EXPORT_SYMBOL please. David - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL P

[2.6 patch] kill net/rxrpc/rxrpc_syms.c

2007-02-19 Thread Adrian Bunk
This patch moves the EXPORT_SYMBOL's from net/rxrpc/rxrpc_syms.c to the files with the actual functions. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- This patch was already sent on: - 26 Nov 2006 net/rxrpc/Makefile |1 - net/rxrpc/call.c |5 + net/rxrpc/connection.

Re: [2.6 patch] kill net/rxrpc/rxrpc_syms.c

2006-11-28 Thread David Howells
Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > This patch moves the EXPORT_SYMBOL's from net/rxrpc/rxrpc_syms.c to the > > > files with the actual functions. > > > > You can if you like. Can you slap a blank line before each EXPORT_SYMBOL() > > though please? > > Updated patch below. Acked-By:

Re: [2.6 patch] kill net/rxrpc/rxrpc_syms.c

2006-11-27 Thread Arnaldo Carvalho de Melo
On 11/28/06, Andrew Morton <[EMAIL PROTECTED]> wrote: On Mon, 27 Nov 2006 11:21:25 + David Howells <[EMAIL PROTECTED]> wrote: > Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > This patch moves the EXPORT_SYMBOL's from net/rxrpc/rxrpc_syms.c to the > > files with the actual functions. > > You ca

Re: [2.6 patch] kill net/rxrpc/rxrpc_syms.c

2006-11-27 Thread Andrew Morton
On Mon, 27 Nov 2006 11:21:25 + David Howells <[EMAIL PROTECTED]> wrote: > Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > This patch moves the EXPORT_SYMBOL's from net/rxrpc/rxrpc_syms.c to the > > files with the actual functions. > > You can if you like. Can you slap a blank line before each

[2.6 patch] kill net/rxrpc/rxrpc_syms.c

2006-11-27 Thread Adrian Bunk
On Mon, Nov 27, 2006 at 11:21:25AM +, David Howells wrote: > Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > This patch moves the EXPORT_SYMBOL's from net/rxrpc/rxrpc_syms.c to the > > files with the actual functions. > > You can if you like. Can you slap a blank line before each EXPORT_SYMBOL

Re: [2.6 patch] kill net/rxrpc/rxrpc_syms.c

2006-11-27 Thread David Howells
Adrian Bunk <[EMAIL PROTECTED]> wrote: > This patch moves the EXPORT_SYMBOL's from net/rxrpc/rxrpc_syms.c to the > files with the actual functions. You can if you like. Can you slap a blank line before each EXPORT_SYMBOL() though please? David - To unsubscribe from this list: send the line "un

[2.6 patch] kill net/rxrpc/rxrpc_syms.c

2006-11-25 Thread Adrian Bunk
This patch moves the EXPORT_SYMBOL's from net/rxrpc/rxrpc_syms.c to the files with the actual functions. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- net/rxrpc/Makefile |1 - net/rxrpc/call.c |5 + net/rxrpc/connection.c |2 ++ net/rxrpc/rxrpc_syms.c | 34